Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: Use explicit go-runtime-metrics-internal version #3013

Merged

Conversation

felixge
Copy link
Member

@felixge felixge commented Dec 6, 2024

What does this PR do?

go.mod: Use explicit go-runtime-metrics-internal version

As suggested in
https://github.com/DataDog/go-runtime-metrics-internal/issues/10
the go-runtime-metrics-internal has been tagged with explicit versions.

This should have already fixed #3011 as future `go get -u ./...`
invocations should resolve to v0.0.3 (same as v0.0.1). See the issue
above for more details.

Fixes #3011

Motivation

Fix the issue.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@felixge felixge force-pushed the felix.geisendoerfer/explicit-go-runtime-metrics-version branch from a4f3097 to 862df05 Compare December 6, 2024 07:44
@pr-commenter
Copy link

pr-commenter bot commented Dec 6, 2024

Benchmarks

Benchmark execution time: 2024-12-06 09:20:31

Comparing candidate commit a7c6d95 in PR branch felix.geisendoerfer/explicit-go-runtime-metrics-version with baseline commit 9980c24 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

As suggested in
DataDog/go-runtime-metrics-internal#10
the go-runtime-metrics-internal has been tagged with explicit versions.

This should have already fixed #3011 as future `go get -u ./...`
invocations should resolve to v0.0.3 (same as v0.0.1). See the issue
above for more details.

Fixes #3011
@felixge felixge force-pushed the felix.geisendoerfer/explicit-go-runtime-metrics-version branch from 862df05 to a7c6d95 Compare December 6, 2024 08:37
@felixge felixge merged commit 17415ba into main Dec 6, 2024
182 checks passed
@felixge felixge deleted the felix.geisendoerfer/explicit-go-runtime-metrics-version branch December 6, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants