Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/aws: add go.mod to isolate contrib #2357

Merged
merged 16 commits into from
Nov 22, 2023

Conversation

darccio
Copy link
Member

@darccio darccio commented Nov 15, 2023

What does this PR do?

Isolates contrib/aws as an independent module, and adds the support for running contrib modules' tests in CI.

This will be done for each contrib, and this is a first PR to validate the approach. Next PRs will consist of multiple contribs.

Motivation

Security scanners yield false positives, informing vulnerable versions that are present in the go.mod but not compiled into the final binary.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@darccio darccio requested a review from a team November 15, 2023 10:50
@darccio darccio requested a review from a team as a code owner November 15, 2023 10:50
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Nov 15, 2023
@pr-commenter
Copy link

pr-commenter bot commented Nov 20, 2023

Benchmarks

Benchmark execution time: 2023-11-21 13:52:58

Comparing candidate commit 1a03b23 in PR branch dario.castane/AIT-8717/isolate-contribs with baseline commit 0fa8d63 in branch v2-dev.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

@darccio
Copy link
Member Author

darccio commented Nov 21, 2023

CI is working:

image
image
image

@darccio darccio merged commit d9ad3a9 into v2-dev Nov 22, 2023
48 checks passed
@darccio darccio deleted the dario.castane/AIT-8717/isolate-contribs branch November 22, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants