Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/jackc/pgx.v5: wrap previous tracer #2932

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Oct 17, 2024

What does this PR do?

Fixes #2908

Wrap the previous tracer if there was one instead of replacing it.

Additionally, it adds ConnectWithOptions which is the traced version of the original pgx.ConnectWithOptions.

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Oct 17, 2024
@pr-commenter
Copy link

pr-commenter bot commented Oct 17, 2024

Benchmarks

Benchmark execution time: 2024-10-21 09:02:36

Comparing candidate commit fcc12fe in PR branch rarguelloF/fix-pgx-override-tracer with baseline commit f65cab8 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

@rarguelloF rarguelloF marked this pull request as ready for review October 17, 2024 15:31
@rarguelloF rarguelloF requested review from a team as code owners October 17, 2024 15:31
@darccio darccio merged commit 1366f6b into main Oct 21, 2024
146 checks passed
@darccio darccio deleted the rarguelloF/fix-pgx-override-tracer branch October 21, 2024 09:25
darccio added a commit that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The pgx integration silently overwrites other tracers
2 participants