fix(ddtrace/tracer): TestTracerTwiceStartRuntimeMetrics #4086
+26
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Calling
tracer.Start()implicitly stops any existing tracer before starting a new one. This was not working correctly for runtime metrics v2, causing a secondStart()call to stop the existing runtime metrics v2 emitter, but not starting a new one and printing an error to the log instead.This PR adds a test case to reproduce the issue as well as a fix.
Motivation
ZD 2321693 has an example of somebody running into this issue.
It's possible that the problem in that ticket is caused by an unintended second call to
Start(), but that's a separate issue.Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!