Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the benchmark timeout from 15 to 20 minutes #5286

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

watson
Copy link
Collaborator

@watson watson commented Feb 17, 2025

What does this PR do?

Increases the benchmark CI timeout from 15 minutes to 20 minutes.

Motivation

Today we have been hit the 15 minute timeout several times. Increasing to 20 to reduce flakyness.

Plugin Checklist

Additional Notes

@watson watson self-assigned this Feb 17, 2025
Copy link
Collaborator Author

watson commented Feb 17, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Feb 17, 2025

Overall package size

Self size: 8.75 MB
Deduped: 94.95 MB
No deduping: 95.47 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (14a3795) to head (a6fe27c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5286      +/-   ##
==========================================
+ Coverage   80.87%   80.91%   +0.04%     
==========================================
  Files         484      488       +4     
  Lines       21783    21817      +34     
==========================================
+ Hits        17616    17654      +38     
+ Misses       4167     4163       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 17, 2025

Datadog Report

Branch report: watson/bump-bench-timeout
Commit report: f96ce1d
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 674 Passed, 0 Skipped, 14m 38.05s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 17, 2025

Benchmarks

Benchmark execution time: 2025-02-18 14:26:48

Comparing candidate commit a6fe27c in PR branch watson/bump-bench-timeout with baseline commit 14a3795 in branch master.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 912 metrics, 19 unstable metrics.

scenario:plugin-graphql-with-async-hooks-18

  • 🟥 execution_time [+277.305ms; +298.693ms] or [+5.723%; +6.165%]
  • 🟥 max_rss_usage [+91.826MB; +96.306MB] or [+17.388%; +18.236%]

@watson watson marked this pull request as ready for review February 17, 2025 20:34
@watson watson requested a review from a team as a code owner February 17, 2025 20:34
@watson watson merged commit 0e84146 into master Feb 18, 2025
360 checks passed
@watson watson deleted the watson/bump-bench-timeout branch February 18, 2025 14:56
@rochdev
Copy link
Member

rochdev commented Feb 19, 2025

Today we have been hit the 15 minute timeout several times. Increasing to 20 to reduce flakyness.

The timeout is there to prevent the very issue that this PR is bypassing. Let's make the benchmark run faster instead of just keep increasing the timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants