Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PackageUpdater failure #3078

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Conversation

PROFeNoM
Copy link
Contributor

@PROFeNoM PROFeNoM commented Feb 10, 2025

Description

In #3062, IntegrationTestCase was updated to declare getAppIndexScript and getConsoleScript. Since these methods now exist on any test suite extending IntegrationTestCase, we had this type of failures:

- Error processing /home/circleci/app/tests/Integrations/AMQP/Latest/AMQPTest.php: dirname(): Argument #1 ($path) must be of type string, null given
#0 /home/circleci/app/tests/PackageUpdater.php(94): dirname(NULL)
#1 /home/circleci/app/tests/PackageUpdater.php(66): PackageUpdater->findComposerFile('DDTrace\\Tests\\I...', '/home/circleci/...')
#2 /home/circleci/app/tests/PackageUpdater.php(21): PackageUpdater->processFile('/home/circleci/...')
#3 /home/circleci/app/tests/PackageUpdater.php(185): PackageUpdater->run()
#4 {main}

This fix just proposes to check whether it's null + exit 1 when errors are encountered.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@PROFeNoM PROFeNoM self-assigned this Feb 10, 2025
@PROFeNoM PROFeNoM requested a review from a team as a code owner February 10, 2025 08:37
@PROFeNoM PROFeNoM requested a review from a team February 10, 2025 08:37
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.74%. Comparing base (c199419) to head (8427e87).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #3078       +/-   ##
=============================================
+ Coverage     51.86%   74.74%   +22.87%     
  Complexity     2790     2790               
=============================================
  Files           112      112               
  Lines         11042    11042               
=============================================
+ Hits           5727     8253     +2526     
+ Misses         5315     2789     -2526     
Flag Coverage Δ
tracer-php 74.74% <ø> (+22.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 20 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c199419...8427e87. Read the comment docs.

Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good :-)

@PROFeNoM PROFeNoM merged commit b8e8454 into master Feb 10, 2025
678 of 701 checks passed
@PROFeNoM PROFeNoM deleted the alex/fix/packageupdater-failure-dir-null branch February 10, 2025 14:18
@github-actions github-actions bot added this to the 1.7.0 milestone Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants