Skip to content

Commit

Permalink
chore(langchain): make langchain version skip conditional less precis…
Browse files Browse the repository at this point in the history
…e for CI (#9997)

Even after #9768 we're still seeing some tests be skipped on CI,
specifically `langchain-community` tests even when `langchain>=0.1`. My
suspicion is that the `sys.version_info < (0, 1, 0)` conditional that is
used for the test skipping is too precise for the versions of Langchain
being run on CI (not exactly sure what the issue is, but I've narrowed
it down to that area). This PR only checks the major and minor version
of Langchain being run

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
  • Loading branch information
Yun-Kim authored Jul 31, 2024
1 parent 2f7063b commit 65240c1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/contrib/langchain/test_langchain_community.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

LANGCHAIN_VERSION = parse_version(langchain.__version__)

pytestmark = pytest.mark.skipif(LANGCHAIN_VERSION < (0, 1, 0), reason="This module only tests langchain >= 0.1")
pytestmark = pytest.mark.skipif(LANGCHAIN_VERSION < (0, 1), reason="This module only tests langchain >= 0.1")

IGNORE_FIELDS = [
"resources",
Expand Down

0 comments on commit 65240c1

Please sign in to comment.