Skip to content

Commit

Permalink
chore: extend pyramid flaky test timestamp (#11369)
Browse files Browse the repository at this point in the history
The pyramid test flaky marker was set to Jan 2024 so it is expired by
now. This PR updates the test.

While looking at the failed pipelines, example:
https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/703862626

One of the reasons it fails is because there's a new base service name
and it is no longer blank:
```
meta mismatch on '_dd.base_service': got 'tests.contrib.pyramid.app' which does not match expected ''.
```
Related to #11274

Also, this PR sets a new flaky timestamp because the pyramid sample app
doesn't spin up correctly in the subprocesses, leading to failed tests.

Relates to AIDM-483

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
  • Loading branch information
wantsui authored Nov 20, 2024
1 parent 7e1bb89 commit 78d35a2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tests/contrib/pyramid/test_pyramid.py
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ def pyramid_client(snapshot, pyramid_app):
proc.terminate()


@flaky(until=1706677200)
@flaky(1740089353, reason="Sample app doesn't seem to spin up in subprocess")
@pytest.mark.parametrize(
"pyramid_app",
[
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"type": "web",
"error": 0,
"meta": {
"_dd.base_service": "",
"_dd.base_service": "tests.contrib.pyramid.app",
"_dd.p.dm": "-0",
"_dd.p.tid": "654a694400000000",
"component": "pyramid",
Expand Down

0 comments on commit 78d35a2

Please sign in to comment.