-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(di): trigger probes #10942
base: main
Are you sure you want to change the base?
chore(di): trigger probes #10942
Conversation
|
BenchmarksBenchmark execution time: 2025-01-09 11:17:08 Comparing candidate commit 2d85475 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 393 metrics, 2 unstable metrics. scenario:httppropagationextract-all_styles_all_headers
|
a804567
to
766843f
Compare
Datadog ReportBranch report: ✅ 0 Failed, 1468 Passed, 0 Skipped, 22m 20.08s Total duration (14m 7.33s time saved) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very cool progress, thank you
965b6e6
to
59e7d30
Compare
f8ea66c
to
07f7061
Compare
We implement trigger probes. These allows triggering the capture of debug information along a trace, ensuring all the relevant probes are also triggered.
07f7061
to
a6af837
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
89c83aa
to
118ecb1
Compare
118ecb1
to
346a578
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only thing that left is probe budget for probe with session
ddtrace/debugging/_origin/span.py
Outdated
except KeyError: | ||
# No snapshot was created | ||
return | ||
self.set("start_time", monotonic_ns()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is now happen at the end of the signal. maybe this line should go back to enter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah of course 🤦
"a,b", | ||
[ | ||
("session1:1.session2:2", "session1.session2:2"), | ||
("session1:0.session2:2", "session1:0.session2:2"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think those test could benefit with validate that parsed session are correct as well. that we decode sesion id and level as expected and we got sessions.
second, can you add a test with just session1.session2 to ensure default level works?
We implement trigger probes. These allows triggering the capture of debug information along a trace, ensuring all the relevant probes are also triggered.
Checklist
Reviewer Checklist