Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(telemetry): configuration telemetry reporting #11115

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Oct 22, 2024

We refactor the implementation of the telemetry configuration reporting to use new API exposed by the latest release of envier. We also implement a configuration class that automatically reports configuration telemetry after the environment variables have been parsed and validated.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

We refactor the implementation of the telemetry configuration reporting
to use new API exposed by the latest release of envier. We also
implement a configuration class that automatically reports configuration
telemetry after the environment variables have been parsed and
validated.
@P403n1x87 P403n1x87 added the changelog/no-changelog A changelog entry is not required for this PR. label Oct 22, 2024
Copy link
Contributor

github-actions bot commented Oct 22, 2024

CODEOWNERS have been resolved as:

.riot/requirements/1215c62.txt                                          @DataDog/apm-python
.riot/requirements/132f882.txt                                          @DataDog/apm-python
.riot/requirements/1dcfbb2.txt                                          @DataDog/apm-python
.riot/requirements/bd5e098.txt                                          @DataDog/apm-python
ddtrace/settings/_core.py                                               @DataDog/apm-core-python
ddtrace/settings/peer_service.py                                        @DataDog/apm-core-python
hatch.toml                                                              @DataDog/python-guild
min_compatible_versions.csv                                             @DataDog/apm-core-python
pyproject.toml                                                          @DataDog/python-guild
riotfile.py                                                             @DataDog/apm-python
tests/telemetry/test_writer.py                                          @DataDog/apm-python
.riot/requirements/1e6bfcb.txt                                          @DataDog/apm-python
.riot/requirements/1f540f4.txt                                          @DataDog/apm-python
.riot/requirements/6498eb0.txt                                          @DataDog/apm-python
.riot/requirements/c23a971.txt                                          @DataDog/apm-python

@P403n1x87 P403n1x87 requested a review from mabdinur October 22, 2024 12:26
@pr-commenter
Copy link

pr-commenter bot commented Oct 22, 2024

Benchmarks

Benchmark execution time: 2025-01-08 15:41:19

Comparing candidate commit 74c150e in PR branch refactor/config-telemetry with baseline commit a225334 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@mabdinur mabdinur requested a review from erikayasuda October 22, 2024 14:55
@mabdinur mabdinur force-pushed the refactor/config-telemetry branch 2 times, most recently from f1d768f to d60ed8d Compare October 22, 2024 17:20
ensure recursivzely defined envier items are captured in telemetry
@mabdinur mabdinur force-pushed the refactor/config-telemetry branch from d60ed8d to 9bdab98 Compare October 22, 2024 17:21
@mabdinur mabdinur changed the title refactor: configuration telemetry reporting fix: configuration telemetry reporting Oct 22, 2024
@mabdinur
Copy link
Contributor

If this change is backported to the 2.15 branch before 2.15.0 is released then a release note is not required.
Otherwise we need to document the fact that v2.15.0 relies on private attributes in a third party library (envier).

cc: @erikayasuda

@mabdinur mabdinur marked this pull request as ready for review October 22, 2024 17:27
@mabdinur mabdinur requested review from a team as code owners October 22, 2024 17:27
hatch.toml Show resolved Hide resolved
hatch.toml Show resolved Hide resolved
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Oct 23, 2024

Datadog Report

Branch report: refactor/config-telemetry
Commit report: 74c150e
Test service: dd-trace-py

✅ 0 Failed, 87 Passed, 1468 Skipped, 4m 11.97s Total duration (35m 21.08s time saved)

ddtrace/settings/_core.py Outdated Show resolved Hide resolved
ddtrace/settings/peer_service.py Show resolved Hide resolved
@mabdinur mabdinur enabled auto-merge (squash) October 25, 2024 18:18
ddtrace/settings/_core.py Outdated Show resolved Hide resolved
@mabdinur mabdinur changed the title fix: configuration telemetry reporting chore(telemetry): configuration telemetry reporting Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants