chore(service-naming): improve inferred service naming algorithm #11458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…ervice-naming-algo
Datadog ReportBranch report: ✅ 0 Failed, 1468 Passed, 0 Skipped, 23m 45.06s Total duration (12m 29.97s time saved) |
wconti27
changed the title
BenchmarksBenchmark execution time: 2024-11-20 22:09:34 Comparing candidate commit 851a5fe in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 388 metrics, 2 unstable metrics. |
wconti27
added
backport 2.17
changelog/no-changelog
raphaelgavache
approved these changes
Nov 20, 2024
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
brettlangdon
approved these changes
Nov 20, 2024
wconti27
commented
Nov 20, 2024
|
/merge |
Devflow running:
|
tabgok
reviewed
Nov 20, 2024
tabgok
reviewed
Nov 20, 2024
|
/remove |
Devflow running:
|
dd-devflow
bot
added
mergequeue-status: removed
and removed
mergequeue-status: waiting
labels
wantsui
approved these changes
Nov 20, 2024
emmettbutler
approved these changes
Nov 20, 2024
wconti27
commented
Nov 20, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
) ## Motivation Updates inferred service naming algorithm. Previously, the service naming algorithm would skip over any flag arguments (args starting with `-`), as well as the following argument as it was assumed to be the argument value. The update changes the algorithm to run again if no service name was found the first time. The second time, the algorithm will not skip arguments that were preceded by a flag argument. Effect: -- Previous Behavior: `pytest --no-cov my/file.py` -> service name = `""` -- New Behavior: `pytest --no-cov my/file.py` -> service name = `"my.file"` Additionally adds check to ensure a python module included after `-m` module is importable before using it as the service name. Also updates the service naming algorithm to use try-catches to prevent any unforeseen errors. Adds many more test cases, fixes a few snapshots. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit 110dcfa)
2 tasks
wconti27
pushed a commit
that referenced
this pull request
Nov 21, 2024
…kport 2.17] (#11475) Backport 110dcfa from #11458 to 2.17. ## Motivation Updates inferred service naming algorithm. Previously, the service naming algorithm would skip over any flag arguments (args starting with `-`), as well as the following argument as it was assumed to be the argument value. The update changes the algorithm to run again if no service name was found the first time. The second time, the algorithm will not skip arguments that were preceded by a flag argument. Effect: -- Previous Behavior: `pytest --no-cov my/file.py` -> service name = `""` -- New Behavior: `pytest --no-cov my/file.py` -> service name = `"my.file"` Additionally adds check to ensure a python module included after `-m` module is importable before using it as the service name. Also updates the service naming algorithm to use try-catches to prevent any unforeseen errors. Adds many more test cases, fixes a few snapshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Updates inferred service naming algorithm. Previously, the service naming algorithm would skip over any flag arguments (args starting with
-), as well as the following argument as it was assumed to be the argument value. The update changes the algorithm to run again if no service name was found the first time. The second time, the algorithm will not skip arguments that were preceded by a flag argument.Effect:
-- Previous Behavior:
pytest --no-cov my/file.py-> service name =""-- New Behavior:
pytest --no-cov my/file.py-> service name ="my.file"Additionally adds check to ensure a python module included after
-mmodule is importable before using it as the service name.Also updates the service naming algorithm to use try-catches to prevent any unforeseen errors.
Adds many more test cases, fixes a few snapshots.
Checklist
Reviewer Checklist