Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: explicitly set resource request/limits for test job #11476

Closed
wants to merge 2 commits into from
Closed

ci: explicitly set resource request/limits for test job #11476

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0353375
explicitly set resource limits
taegyunkim Nov 20, 2024
059f0ae
Merge branch 'main' into taegyunkim/ci-resource-limits
taegyunkim Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .gitlab/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ variables:
# DEV: we have a larger pool of amd64 runners, prefer that over arm64
tags: [ "arch:amd64" ]
timeout: 20m
variables:
KUBERNETES_CPU_REQUEST: 12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be better to have a lower request than limit?

most of our jobs aren't going to use 12 CPUs anyways, majority of them are single threaded.

better to have request 1/2 and limit of 12?

same with memory, request of 3/4 and limit of 16?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, based on how the limits are enforced, requests must equal the limit.

I still wonder if this is too aggressive to apply to all of our testrunner jobs, should we be more targeted?

KUBERNETES_CPU_LIMIT: 12
KUBERNETES_MEMORY_REQUEST: 16Gi
KUBERNETES_MEMORY_LIMIT: 16Gi
before_script:
- pyenv global 3.12 3.7 3.8 3.9 3.10 3.11 3.13-dev
- export _CI_DD_AGENT_URL=http://${HOST_IP}:8126/
Expand Down
Loading