Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Exception Tracking #11732

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ygree
Copy link

@ygree ygree commented Dec 13, 2024

Collect, dedupe, ddtrace.contrib errors reported via DDLogger and send to the telemetry.
Must be an ERROR or a log with an exception and a stack trace.

image

Jira ticket: AIDM-389

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@ygree ygree self-assigned this Dec 13, 2024
Copy link
Contributor

github-actions bot commented Dec 13, 2024

CODEOWNERS have been resolved as:

ddtrace/internal/logger.py                                              @DataDog/apm-core-python
ddtrace/internal/telemetry/writer.py                                    @DataDog/apm-core-python

@pr-commenter
Copy link

pr-commenter bot commented Dec 13, 2024

Benchmarks

Benchmark execution time: 2025-01-07 00:37:57

Comparing candidate commit ec8f7ca in PR branch ygree/integration-exception-tracking with baseline commit 232e2eb in branch ``.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@ygree ygree marked this pull request as ready for review December 14, 2024 01:53
@ygree ygree requested a review from a team as a code owner December 14, 2024 01:53
@ygree ygree requested a review from erikayasuda December 14, 2024 01:53
ygree added 4 commits January 6, 2025 15:38
Collect, dedupe, ddtrace.contrib logs, and send to the telemetry.
Report only an error or an exception with a stack trace. Added tags and stack trace (without redaction)
@ygree ygree force-pushed the ygree/integration-exception-tracking branch from b11966f to ec8f7ca Compare January 6, 2025 23:57
)


class _TelemetryConfig:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we are introducing telemetry-specific logic into a logging source. Can we try to see if there is a different design that allows keeping the two separate, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants