Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set CMAKE_BUILD_PARALLEL_LEVEL for mac builds #11863

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Jan 6, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Jan 6, 2025

CODEOWNERS have been resolved as:

.github/workflows/build_python_3.yml                                    @DataDog/python-guild @DataDog/apm-core-python
pyproject.toml                                                          @DataDog/python-guild

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 6, 2025

Datadog Report

Branch report: taegyunkim/build-parallel
Commit report: 58ef6e5
Test service: dd-trace-py

✅ 0 Failed, 87 Passed, 1468 Skipped, 3m 57.32s Total duration (35m 22.76s time saved)

@taegyunkim taegyunkim marked this pull request as ready for review January 6, 2025 20:26
@taegyunkim taegyunkim requested review from a team as code owners January 6, 2025 20:26
@taegyunkim taegyunkim added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 6, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jan 6, 2025

Benchmarks

Benchmark execution time: 2025-01-06 20:55:15

Comparing candidate commit 58ef6e5 in PR branch taegyunkim/build-parallel with baseline commit 81208cd in branch main.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 391 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathdirname_aspect

  • 🟥 execution_time [+390.852ns; +456.887ns] or [+10.712%; +12.521%]

scenario:iast_aspects-ospathsplit_aspect

  • 🟥 execution_time [+273.265ns; +342.407ns] or [+7.107%; +8.905%]

scenario:iast_aspects-replace_aspect

  • 🟥 execution_time [+547.409ns; +630.466ns] or [+8.174%; +9.414%]

@taegyunkim taegyunkim merged commit 5ea349e into main Jan 7, 2025
677 of 681 checks passed
@taegyunkim taegyunkim deleted the taegyunkim/build-parallel branch January 7, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants