-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(distributed_tracing): ensure ASM standalone operates on all propagation styles #11875
base: main
Are you sure you want to change the base?
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 1152 Passed, 316 Skipped, 21m 37.1s Total duration (15m 48.29s time saved) |
BenchmarksBenchmark execution time: 2025-01-08 17:53:39 Comparing candidate commit 5126ddc in PR branch Found 0 performance improvements and 4 performance regressions! Performance is the same for 390 metrics, 2 unstable metrics. scenario:iast_aspects-ospathjoin_aspect
scenario:iast_aspects-ospathsplit_aspect
scenario:iast_aspects-ospathsplitdrive_aspect
scenario:iast_aspects-replace_aspect
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving the ASM distributed header propagation to HTTPPropagator
makes sense, but just a little confused why this behavior (disregarded whether tracer was enabled or not) was occuring in the first place.
--- | ||
fixes: | ||
- | | ||
ASM: Fixed an issue where distributed tracing headers were improperly propagated when tracing was disabled. Now, headers are only propagated for traces with the _dd.p.appsec tag, regardless of the propagation style (e.g., TraceContext). Previously, this logic applied only to Datadog headers, potentially allowing invalid trace info to be injected or extracted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify - previously we were only propagating ASM distributed tracing headers on Datadog headers regardless if tracing was enabled/disabled? Is this because DatadogMultiHeaders._inject()
doesn't account for tracing being enabled/disabled?
Checklist
Reviewer Checklist