Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force reimport of modules during serverless test. #11888

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

purple4reina
Copy link
Contributor

Commit 12655ee removed the @pytest.mark.subprocess() from the serverless slow imports test. This effectively rendered the test useless as ddtrace and all required modules had already been imported in the parent process.

Adding the subprocess mark back will ensure that the sys modules are fresh. We must still go through and delete entries because @pytest.mark.subprocess() relies on multiprocessing, so it must be removed so as to ensure it can be reimported if needed.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@purple4reina purple4reina requested a review from a team as a code owner January 9, 2025 22:11
Copy link
Contributor

github-actions bot commented Jan 9, 2025

CODEOWNERS have been resolved as:

tests/internal/test_serverless.py                                       @DataDog/apm-core-python

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: rey.abolofia/fix-sls-test
Commit report: 07c753d
Test service: dd-trace-py

✅ 0 Failed, 87 Passed, 1468 Skipped, 4m 4.78s Total duration (35m 36.44s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 9, 2025

Benchmarks

Benchmark execution time: 2025-01-09 22:47:14

Comparing candidate commit 07c753d in PR branch rey.abolofia/fix-sls-test with baseline commit 04ee68f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 208 metrics, 2 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant