Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(di): don't redact env tokens from probe snapshots #11951

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

watson
Copy link

@watson watson commented Jan 15, 2025

Summary of changes

Remove env from list of tokens to redact from Dynamic Instrumentation probe snapshots.

Depends on: DataDog/system-tests#3827

Reason for change

Feature parity

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@watson watson requested a review from a team as a code owner January 15, 2025 14:48
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/debugging/_redaction.py                                         @DataDog/debugger-python

Copy link
Contributor

@P403n1x87 P403n1x87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 thanks!

@P403n1x87 P403n1x87 added changelog/no-changelog A changelog entry is not required for this PR. Dynamic Instrumentation Dynamic Instrumentation/Live Debugger labels Jan 15, 2025
@P403n1x87 P403n1x87 changed the title fix(di): Don't redact env tokens from probe snapshots chore(di): don't redact env tokens from probe snapshots Jan 15, 2025
@P403n1x87 P403n1x87 enabled auto-merge (squash) January 15, 2025 15:24
@pr-commenter
Copy link

pr-commenter bot commented Jan 15, 2025

Benchmarks

Benchmark execution time: 2025-01-15 15:27:31

Comparing candidate commit 9f1911c in PR branch watson/env-redaction with baseline commit fce6d75 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@watson
Copy link
Author

watson commented Jan 15, 2025

I've seen other PRs to this repo being merged with the changelog validation CI check failing. Is that ok in this case as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. Dynamic Instrumentation Dynamic Instrumentation/Live Debugger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants