Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lib-injection): dedupe files in OCI image #11960

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

brettlangdon
Copy link
Member

@brettlangdon brettlangdon commented Jan 15, 2025

This PR introduces using rdfind to dedupe all the files in the OCI image and k8s lib-injection images to reduce the overall size.

https://datadoghq.atlassian.net/browse/INPLAT-442

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Sorry, something went wrong.

Copy link
Contributor

github-actions bot commented Jan 15, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/chore-reduce-oci-image-ce45f1868ee14415.yaml         @DataDog/apm-python
.gitlab/prepare-oci-package.sh                                          @DataDog/python-guild @DataDog/apm-core-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 15, 2025

Datadog Report

Branch report: brettlangdon/oci.dedupe
Commit report: 5840592
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 31.34s Total duration (35m 34.74s time saved)

@brettlangdon brettlangdon changed the title chore: dedupe files in OCI image chore(lib-inbjection): dedupe files in OCI image Jan 15, 2025
@brettlangdon brettlangdon changed the title chore(lib-inbjection): dedupe files in OCI image chore(lib-injection): dedupe files in OCI image Jan 15, 2025
@brettlangdon brettlangdon added changelog/no-changelog A changelog entry is not required for this PR. and removed changelog/no-changelog A changelog entry is not required for this PR. labels Jan 15, 2025
@brettlangdon brettlangdon marked this pull request as ready for review January 15, 2025 18:15
@brettlangdon brettlangdon requested review from a team as code owners January 15, 2025 18:15
@pr-commenter
Copy link

pr-commenter bot commented Jan 15, 2025

Benchmarks

Benchmark execution time: 2025-01-15 18:59:27

Comparing candidate commit 5840592 in PR branch brettlangdon/oci.dedupe with baseline commit 21d50d4 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 378 metrics, 2 unstable metrics.

Copy link
Contributor

@erikayasuda erikayasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@stanistan stanistan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@brettlangdon brettlangdon merged commit 4084e8a into main Jan 17, 2025
617 of 619 checks passed
@brettlangdon brettlangdon deleted the brettlangdon/oci.dedupe branch January 17, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants