refactor(profiling): add more GIL assertions to memalloc #12000
Merged
+11
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first GIL assertion I added, to
memalloc_add_event
, has not trippedyet on a test application. One the one hand, it's reassuring that we
always see the GIL in that part of the code. On the other hand, there
are other parts of the memory profiler that could in theory be called
concurrently where I didn't add the assertion: when stopping the
profiler, and when iterating over the events to aggregate them. Add GIL
assertions to those points. The goal is ultimately to understand why we
needed to add locks to the profiler to prevent it from crashing, given
that the GIL exists.
Checklist
Reviewer Checklist