Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(tracing): only extract distributed headers if a trace is not already started" #12008

Merged

Conversation

brettlangdon
Copy link
Member

@brettlangdon brettlangdon commented Jan 21, 2025

Reverts #9456

This PR was merged automatically even though there was a failing system test. https://github.com/DataDog/dd-trace-py/actions/runs/12836948874/job/35799900676

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/contrib/trace_utils.py                                          @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/settings/config.py                                              @DataDog/python-guild @DataDog/apm-sdk-api-python
tests/contrib/wsgi/test_wsgi.py                                         @DataDog/apm-core-python @DataDog/apm-idm-python
tests/utils.py                                                          @DataDog/python-guild

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: revert-9456-brettlangdon/fix.extra.distributed.extract
Commit report: 1809698
Test service: dd-trace-py

✅ 0 Failed, 1048 Passed, 550 Skipped, 17m 10.77s Total duration (22m 14.15s time saved)

@brettlangdon brettlangdon added changelog/no-changelog A changelog entry is not required for this PR. and removed changelog/no-changelog A changelog entry is not required for this PR. labels Jan 21, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jan 21, 2025

Benchmarks

Benchmark execution time: 2025-01-21 14:12:58

Comparing candidate commit 1809698 in PR branch revert-9456-brettlangdon/fix.extra.distributed.extract with baseline commit 731be65 in branch main.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 391 metrics, 2 unstable metrics.

scenario:flasksqli-appsec-enabled

  • 🟥 execution_time [+156.594µs; +166.028µs] or [+7.250%; +7.686%]

scenario:flasksqli-iast-enabled

  • 🟥 execution_time [+158.052µs; +167.485µs] or [+7.320%; +7.757%]

scenario:flasksqli-tracer-enabled

  • 🟥 execution_time [+162.724µs; +172.811µs] or [+7.579%; +8.049%]

@avara1986 avara1986 merged commit 4611816 into main Jan 21, 2025
711 of 714 checks passed
@avara1986 avara1986 deleted the revert-9456-brettlangdon/fix.extra.distributed.extract branch January 21, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants