Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(integrations): remove deprecated code [3.0] #12105

Open
wants to merge 35 commits into
base: munir/upgrade-min-aws-lambda
Choose a base branch
from

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Jan 27, 2025

Motivation

Ensures the implementation details for all integrations are internal.

Changes

  • Removes all deprecated modules and packages from ddtrace/contrib
  • For integrations that no not expose public attributes:
    • Removes ddtrace.contrib.integration_name package
    • Moves the integration docs from ddtrace.contrib.integration_name.__init__ to ddtrace.contrib._integration_name.py.
  • For integrations that expose public attributes:
    • Removes ddtrace.contrib.integration_name package
    • Removes deprecated attributes from ddtrace.contrib.integration_name.__init__ to ddtrace.contrib.integration_name
    • Renames ddtrace.contrib.integration_name.__init__ to ddtrace.contrib.integration_name.

Blocked by: #12107

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Jan 27, 2025

CODEOWNERS have been resolved as:

ddtrace/contrib/_aiohttp_jinja2.py                                      @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_asyncio.py                                             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_azure_functions.py                                     @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_coverage.py                                            @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_langgraph.py                                           @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_pytest_benchmark.py                                    @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_urllib.py                                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_webbrowser.py                                          @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/bottle.py                                               @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/pylibmc.py                                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/sqlalchemy.py                                           @DataDog/apm-core-python @DataDog/apm-idm-python
releasenotes/notes/remove-deprecated-code-integrations-ae6970bbf9b10047.yaml  @DataDog/apm-python
ddtrace/contrib/__init__.py                                             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/aiohttp/middlewares.py                         @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/requests/patch.py                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/requests/session.py                            @DataDog/apm-core-python @DataDog/apm-idm-python
docs/advanced_usage.rst                                                 @DataDog/python-guild
docs/integrations.rst                                                   @DataDog/python-guild
tests/appsec/suitespec.yml                                              @DataDog/asm-python
tests/ci_visibility/suitespec.yml                                       @DataDog/ci-app-libraries
tests/contrib/suitespec.yml                                             @DataDog/apm-core-python @DataDog/apm-idm-python
tests/internal/test_module.py                                           @DataDog/debugger-python @DataDog/apm-core-python
tests/llmobs/suitespec.yml                                              @DataDog/ml-observability
tests/opentracer/test_tracer_asyncio.py                                 @DataDog/apm-core-python
tests/opentracer/test_tracer_gevent.py                                  @DataDog/apm-core-python
ddtrace/contrib/_aiobotocore.py                                         @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_aiomysql.py                                            @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_aiopg.py                                               @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_aioredis.py                                            @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_algoliasearch.py                                       @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_anthropic.py                                           @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_aredis.py                                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_asyncpg.py                                             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_avro.py                                                @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_aws_lambda.py                                          @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_boto.py                                                @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_botocore.py                                            @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_cassandra.py                                           @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_consul.py                                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_django.py                                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_dogpile_cache.py                                       @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_dramatiq.py                                            @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_elasticsearch.py                                       @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_fastapi.py                                             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_flask.py                                               @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_freezegun.py                                           @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_futures.py                                             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_gevent.py                                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_google_generativeai.py                                 @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_graphql.py                                             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_grpc.py                                                @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_gunicorn.py                                            @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_httplib.py                                             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_httpx.py                                               @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_jinja2.py                                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_kafka.py                                               @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_kombu.py                                               @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_langchain.py                                           @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_logbook.py                                             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_logging.py                                             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_loguru.py                                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_mako.py                                                @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_mariadb.py                                             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_molten.py                                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_mongoengine.py                                         @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_mysql.py                                               @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_mysqldb.py                                             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_openai.py                                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_protobuf.py                                            @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_psycopg.py                                             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_pymemcache.py                                          @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_pymongo.py                                             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_pymysql.py                                             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_pynamodb.py                                            @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_pyodbc.py                                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_pytest.py                                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_pytest_bdd.py                                          @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_redis.py                                               @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_rediscluster.py                                        @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_rq.py                                                  @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_sanic.py                                               @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_selenium.py                                            @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_snowflake.py                                           @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_sqlite3.py                                             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_starlette.py                                           @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_structlog.py                                           @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_subprocess.py                                          @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_unittest.py                                            @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_urllib3.py                                             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_vertexai.py                                            @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_vertica.py                                             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_yaaredis.py                                            @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/aiohttp.py                                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/asgi.py                                                 @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/celery.py                                               @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/cherrypy.py                                             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/dbapi.py                                                @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/dbapi_async.py                                          @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/falcon.py                                               @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/flask_cache.py                                          @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/pyramid.py                                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/requests.py                                             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/tornado.py                                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/wsgi.py                                                 @DataDog/apm-core-python @DataDog/apm-idm-python

@pr-commenter
Copy link

pr-commenter bot commented Jan 27, 2025

Benchmarks

Benchmark execution time: 2025-01-31 02:44:13

Comparing candidate commit cc81d15 in PR branch munir/remove-deprecated-code-integrations with baseline commit ff6120c in branch munir/upgrade-min-aws-lambda.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@mabdinur mabdinur force-pushed the munir/remove-deprecated-code-integrations branch 3 times, most recently from d64f526 to baf197e Compare January 27, 2025 20:05
@mabdinur mabdinur changed the title chore(integrations): remove deprecated code chore(integrations): remove deprecated code [3.0] Jan 27, 2025
@mabdinur mabdinur force-pushed the munir/remove-deprecated-code-integrations branch from baf197e to 3afb70a Compare January 27, 2025 23:17
@mabdinur mabdinur changed the base branch from main to munir/ensure-all-integrations-have-patch-module January 27, 2025 23:20
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 28, 2025

Datadog Report

Branch report: munir/remove-deprecated-code-integrations
Commit report: cc81d15
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1378 Skipped, 4m 5.8s Total duration (35m 7.39s time saved)

Base automatically changed from munir/ensure-all-integrations-have-patch-module to 3.x-staging January 29, 2025 20:19
@mabdinur mabdinur marked this pull request as ready for review January 29, 2025 21:22
@mabdinur mabdinur requested review from a team as code owners January 29, 2025 21:22
@mabdinur mabdinur requested a review from a team as a code owner January 30, 2025 02:02
@mabdinur mabdinur changed the base branch from 3.x-staging to munir/upgrade-min-aws-lambda January 31, 2025 02:03
@mabdinur mabdinur force-pushed the munir/upgrade-min-aws-lambda branch from ff14361 to 8d2d4e8 Compare January 31, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants