Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(asm): meta struct enable by default for 3.0 #12117

Merged

Conversation

christophe-papazian
Copy link
Contributor

@christophe-papazian christophe-papazian commented Jan 28, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

CODEOWNERS have been resolved as:

releasenotes/notes/msgpack_for_appsec-e09c17e9cb568379.yaml             @DataDog/apm-python
ddtrace/settings/asm.py                                                 @DataDog/asm-python

@christophe-papazian christophe-papazian changed the title meta struct enable by default for 3.0 feat(asm): meta struct enable by default for 3.0 Jan 28, 2025
@christophe-papazian christophe-papazian added the ASM Application Security Monitoring label Jan 28, 2025
@christophe-papazian christophe-papazian marked this pull request as ready for review January 28, 2025 09:21
@christophe-papazian christophe-papazian requested review from a team as code owners January 28, 2025 09:21
@christophe-papazian christophe-papazian requested review from taegyunkim and sabrenner and removed request for a team January 28, 2025 09:21
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: christophe-papazian/use_msgpack_for_appsec
Commit report: 77d8474
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 39.32s Total duration (35m 48.02s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 28, 2025

Benchmarks

Benchmark execution time: 2025-01-28 16:25:03

Comparing candidate commit 19d76c6 in PR branch christophe-papazian/use_msgpack_for_appsec with baseline commit 51659f7 in branch 3.x-staging.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@christophe-papazian christophe-papazian enabled auto-merge (squash) January 28, 2025 15:34
@christophe-papazian christophe-papazian merged commit 8a5477a into 3.x-staging Jan 28, 2025
309 of 311 checks passed
@christophe-papazian christophe-papazian deleted the christophe-papazian/use_msgpack_for_appsec branch January 28, 2025 16:26
gnufede pushed a commit that referenced this pull request Feb 19, 2025
## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants