-
Notifications
You must be signed in to change notification settings - Fork 443
feat(llmobs): add span processor #13426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 229 ± 2 ms. The average import time from base is: 231 ± 1 ms. The import time difference between this PR and base is: -2.37 ± 0.07 ms. Import time breakdownThe following import paths have shrunk:
|
Add capability to add a span processor. The processor can be used to mutate or redact sensitive data contained in inputs and outputs from LLM calls. ```python def my_processor(span): for message in span.output_messages: message["content"] = "" LLMObs.enable(span_processor=my_processor) LLMObs.add_processor(my_processor) ```
35b25f4
to
230b1ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the api, logic, and cases tested LGTM! nice job on telemetry as well 😎 just a couple questions, will approve after resolving them 😄
also - i think it should be register_processor
instead of add_processor
the PR description code block for clarity for folks who come to the PR looking at the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for changing the field names, i think it unblocks us from adding the other i/o types down the road!
9b51e9e
to
a8bd309
Compare
6f6759f
to
e4e5579
Compare
c29da46
to
a561da0
Compare
Add capability to add a span processor. The processor can be used to mutate or redact sensitive data contained in inputs and outputs from LLM calls. ```python from ddtrace.llmobs import LLMObsSpan def my_processor(span: LLMObsSpan): for message in span.output: message["content"] = "" LLMObs.enable(span_processor=my_processor) LLMObs.register_processor(my_processor) ``` Public docs: DataDog/documentation#29365 Shared tests: TODO Closes: #11179 (cherry picked from commit cc8e98c)
Backport cc8e98c from #13426 to 3.8. Add capability to add a span processor. The processor can be used to mutate or redact sensitive data contained in inputs and outputs from LLM calls. ```python from ddtrace.llmobs import LLMObsSpan def my_processor(span: LLMObsSpan): for message in span.output: message["content"] = "" LLMObs.enable(span_processor=my_processor) LLMObs.register_processor(my_processor) ``` Public docs: DataDog/documentation#29365 Shared tests: TODO Closes: #11179 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) [](https://datadoghq.atlassian.net/browse/MLOB-2712) Co-authored-by: kyle <[email protected]>
Add capability to add a span processor. The processor can be used to mutate or redact sensitive data contained in inputs and outputs from LLM calls.
Public docs: DataDog/documentation#29365
Shared tests: TODO
Closes: #11179
Checklist
Reviewer Checklist