Skip to content

feat(llmobs): add span processor #13426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 22, 2025
Merged

feat(llmobs): add span processor #13426

merged 7 commits into from
May 22, 2025

Conversation

Kyle-Verhoog
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog commented May 15, 2025

Add capability to add a span processor. The processor can be used to mutate or redact sensitive data contained in inputs and outputs from LLM calls.

from ddtrace.llmobs import LLMObsSpan

def my_processor(span: LLMObsSpan):
    for message in span.output:
        message["content"] = ""

LLMObs.enable(span_processor=my_processor)

LLMObs.register_processor(my_processor)

Public docs: DataDog/documentation#29365
Shared tests: TODO

Closes: #11179

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented May 15, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/llmobs-processor-d5cb47b12bc3bbd1.yaml               @DataDog/apm-python
ddtrace/llmobs/__init__.py                                              @DataDog/ml-observability
ddtrace/llmobs/_llmobs.py                                               @DataDog/ml-observability
ddtrace/llmobs/_telemetry.py                                            @DataDog/ml-observability
tests/llmobs/_utils.py                                                  @DataDog/ml-observability
tests/llmobs/conftest.py                                                @DataDog/ml-observability
tests/llmobs/test_llmobs.py                                             @DataDog/ml-observability
tests/llmobs/test_llmobs_service.py                                     @DataDog/ml-observability

Copy link
Contributor

github-actions bot commented May 15, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 229 ± 2 ms.

The average import time from base is: 231 ± 1 ms.

The import time difference between this PR and base is: -2.37 ± 0.07 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.041 ms (0.89%)
ddtrace.bootstrap.sitecustomize 1.340 ms (0.59%)
ddtrace.bootstrap.preload 1.340 ms (0.59%)
ddtrace.internal.remoteconfig.client 0.655 ms (0.29%)
ddtrace 0.701 ms (0.31%)
ddtrace._logger 0.028 ms (0.01%)
logging 0.028 ms (0.01%)
traceback 0.028 ms (0.01%)
contextlib 0.028 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented May 15, 2025

Benchmarks

Benchmark execution time: 2025-05-22 04:10:11

Comparing candidate commit 50f059f in PR branch kylev/io-processor with baseline commit 8ee6868 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 507 metrics, 5 unstable metrics.

Add capability to add a span processor. The processor can be used to mutate or
redact sensitive data contained in inputs and outputs from LLM calls.

```python
def my_processor(span):
    for message in span.output_messages:
        message["content"] = ""

LLMObs.enable(span_processor=my_processor)

LLMObs.add_processor(my_processor)
```
Copy link
Contributor

@sabrenner sabrenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the api, logic, and cases tested LGTM! nice job on telemetry as well 😎 just a couple questions, will approve after resolving them 😄

also - i think it should be register_processor instead of add_processor the PR description code block for clarity for folks who come to the PR looking at the changes

Copy link
Contributor

@sabrenner sabrenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for changing the field names, i think it unblocks us from adding the other i/o types down the road!

@Kyle-Verhoog Kyle-Verhoog marked this pull request as ready for review May 19, 2025 17:49
@Kyle-Verhoog Kyle-Verhoog requested review from a team as code owners May 19, 2025 17:49
@Kyle-Verhoog Kyle-Verhoog requested review from wantsui and wconti27 May 19, 2025 17:49
@Kyle-Verhoog Kyle-Verhoog enabled auto-merge (squash) May 22, 2025 03:14
@Kyle-Verhoog Kyle-Verhoog merged commit cc8e98c into main May 22, 2025
353 of 356 checks passed
@Kyle-Verhoog Kyle-Verhoog deleted the kylev/io-processor branch May 22, 2025 04:31
github-actions bot pushed a commit that referenced this pull request May 22, 2025
Add capability to add a span processor. The processor can be used to
mutate or redact sensitive data contained in inputs and outputs from LLM
calls.

```python
from ddtrace.llmobs import LLMObsSpan

def my_processor(span: LLMObsSpan):
    for message in span.output:
        message["content"] = ""

LLMObs.enable(span_processor=my_processor)

LLMObs.register_processor(my_processor)
```

Public docs: DataDog/documentation#29365
Shared tests: TODO

Closes: #11179
(cherry picked from commit cc8e98c)
emmettbutler pushed a commit that referenced this pull request May 22, 2025
Backport cc8e98c from #13426 to 3.8.

Add capability to add a span processor. The processor can be used to
mutate or redact sensitive data contained in inputs and outputs from LLM
calls.

```python
from ddtrace.llmobs import LLMObsSpan

def my_processor(span: LLMObsSpan):
    for message in span.output:
        message["content"] = ""

LLMObs.enable(span_processor=my_processor)

LLMObs.register_processor(my_processor)
```

Public docs: DataDog/documentation#29365
Shared tests: TODO

Closes: #11179

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)


[](https://datadoghq.atlassian.net/browse/MLOB-2712)

Co-authored-by: kyle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need the option to mask the input and output of the LLM API in Datadog LLM observability
5 participants