-
Notifications
You must be signed in to change notification settings - Fork 444
[celery] Celery error callback behavior #13812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
try: | ||
t.get(timeout=self.ASYNC_GET_TIMEOUT) | ||
except ValueError: | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
silent exception (...read more)
Using the pass
statement in an exception block ignores the exception. Exceptions should never be ignored. Instead, the user must add code to notify an exception occurred and attempt to handle it or recover from it.
The exception to this rule is the use of StopIteration
or StopAsyncIteration
when implementing a custom iterator (as those errors are used to acknowledge the end of a successful iteration).
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 272 ± 2 ms. The average import time from base is: 274 ± 1 ms. The import time difference between this PR and base is: -1.91 ± 0.07 ms. Import time breakdownThe following import paths have grown:
|
BenchmarksBenchmark execution time: 2025-06-28 00:15:08 Comparing candidate commit 21bbe43 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 568 metrics, 2 unstable metrics. scenario:iastaspectsospath-ospathbasename_aspect
scenario:iastaspectsospath-ospathnormcase_aspect
|
Demonstrates the issue in #13788 with a test within our Celery tests
I'm testing locally with:
Checklist
Reviewer Checklist