-
Notifications
You must be signed in to change notification settings - Fork 457
chore(iast): ci_visibility interaction #14610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(iast): ci_visibility interaction #14610
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 267 ± 3 ms. The average import time from base is: 280 ± 6 ms. The import time difference between this PR and base is: -13.3 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate avara1986/fix_ci_visibility_iast_interaction (56bd869) with baseline main (67da5b5) 📈 Performance Regressions (1 suite)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.406µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +1.0% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.8% ✅ add_inplace_aspectTime: ✅ 0.408µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +1.4% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.7% ✅ add_inplace_noaspectTime: ✅ 0.315µs (SLO: <10.000µs 📉 -96.8%) vs baseline: -1.9% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.7% ✅ add_noaspectTime: ✅ 0.276µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -0.7% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.7% ✅ bytearray_aspectTime: ✅ 1.288µs (SLO: <10.000µs 📉 -87.1%) vs baseline: -3.0% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.7% ✅ bytearray_extend_aspectTime: ✅ 1.494µs (SLO: <10.000µs 📉 -85.1%) vs baseline: +2.7% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ bytearray_extend_noaspectTime: ✅ 0.617µs (SLO: <10.000µs 📉 -93.8%) vs baseline: +0.5% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +5.0% ✅ bytearray_noaspectTime: ✅ 0.479µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -0.5% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.6% ✅ bytes_aspectTime: ✅ 1.274µs (SLO: <10.000µs 📉 -87.3%) vs baseline: -2.0% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ bytes_noaspectTime: ✅ 0.491µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.8% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.8% ✅ bytesio_aspectTime: ✅ 1.306µs (SLO: <10.000µs 📉 -86.9%) vs baseline: -3.7% Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +4.6% ✅ bytesio_noaspectTime: ✅ 0.498µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.6% Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% ✅ capitalize_aspectTime: ✅ 0.743µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +1.2% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +5.0% ✅ capitalize_noaspectTime: ✅ 0.437µs (SLO: <10.000µs 📉 -95.6%) vs baseline: +0.5% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +4.9% ✅ casefold_aspectTime: ✅ 0.740µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.7% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +5.1% ✅ casefold_noaspectTime: ✅ 0.366µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.3% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.7% ✅ decode_aspectTime: ✅ 0.727µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +0.1% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +5.0% ✅ decode_noaspectTime: ✅ 0.420µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -0.3% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.8% ✅ encode_aspectTime: ✅ 0.711µs (SLO: <10.000µs 📉 -92.9%) vs baseline: ~same Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.7% ✅ encode_noaspectTime: ✅ 0.407µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +2.3% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.8% ✅ format_aspectTime: ✅ 3.436µs (SLO: <10.000µs 📉 -65.6%) vs baseline: +1.4% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.7% ✅ format_map_aspectTime: ✅ 4.051µs (SLO: <10.000µs 📉 -59.5%) vs baseline: 📈 +16.2% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.9% ✅ format_map_noaspectTime: ✅ 0.777µs (SLO: <10.000µs 📉 -92.2%) vs baseline: +0.6% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.6% ✅ format_noaspectTime: ✅ 0.591µs (SLO: <10.000µs 📉 -94.1%) vs baseline: -0.6% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.8% ✅ index_aspectTime: ✅ 0.356µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +1.0% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.9% ✅ index_noaspectTime: ✅ 0.276µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +0.2% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +5.1% ✅ join_aspectTime: ✅ 1.343µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +0.9% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.7% ✅ join_noaspectTime: ✅ 0.488µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -1.3% Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% ✅ ljust_aspectTime: ✅ 2.588µs (SLO: <20.000µs 📉 -87.1%) vs baseline: +1.2% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ ljust_noaspectTime: ✅ 0.399µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.6% Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% ✅ lower_aspectTime: ✅ 2.270µs (SLO: <10.000µs 📉 -77.3%) vs baseline: -1.1% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +4.9% ✅ lower_noaspectTime: ✅ 0.365µs (SLO: <10.000µs 📉 -96.4%) vs baseline: -1.3% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ lstrip_aspectTime: ✅ 2.230µs (SLO: <20.000µs 📉 -88.9%) vs baseline: -1.3% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% ✅ lstrip_noaspectTime: ✅ 0.382µs (SLO: <10.000µs 📉 -96.2%) vs baseline: ~same Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +5.0% ✅ modulo_aspectTime: ✅ 0.994µs (SLO: <10.000µs 📉 -90.1%) vs baseline: ~same Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.7% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.532µs (SLO: <10.000µs 📉 -84.7%) vs baseline: +0.3% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ modulo_aspect_for_bytesTime: ✅ 0.977µs (SLO: <10.000µs 📉 -90.2%) vs baseline: +0.2% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.188µs (SLO: <10.000µs 📉 -88.1%) vs baseline: ~same Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +4.9% ✅ modulo_noaspectTime: ✅ 0.625µs (SLO: <10.000µs 📉 -93.7%) vs baseline: -0.9% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ replace_aspectTime: ✅ 5.106µs (SLO: <10.000µs 📉 -48.9%) vs baseline: +3.3% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.9% ✅ replace_noaspectTime: ✅ 0.459µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -0.7% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.7% ✅ repr_aspectTime: ✅ 0.910µs (SLO: <10.000µs 📉 -90.9%) vs baseline: +0.6% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.8% ✅ repr_noaspectTime: ✅ 0.412µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -1.4% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% ✅ rstrip_aspectTime: ✅ 1.905µs (SLO: <20.000µs 📉 -90.5%) vs baseline: -1.9% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +5.0% ✅ rstrip_noaspectTime: ✅ 0.380µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.5% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +4.9% ✅ slice_aspectTime: ✅ 0.491µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.6% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +4.9% ✅ slice_noaspectTime: ✅ 0.447µs (SLO: <10.000µs 📉 -95.5%) vs baseline: -0.3% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ stringio_aspectTime: ✅ 1.530µs (SLO: <10.000µs 📉 -84.7%) vs baseline: ~same Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.8% ✅ stringio_noaspectTime: ✅ 0.725µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +1.9% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.7% ✅ strip_aspectTime: ✅ 2.219µs (SLO: <20.000µs 📉 -88.9%) vs baseline: -2.4% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.8% ✅ strip_noaspectTime: ✅ 0.384µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.2% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ swapcase_aspectTime: ✅ 2.439µs (SLO: <10.000µs 📉 -75.6%) vs baseline: -2.6% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.6% ✅ swapcase_noaspectTime: ✅ 0.537µs (SLO: <10.000µs 📉 -94.6%) vs baseline: ~same Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% ✅ title_aspectTime: ✅ 2.522µs (SLO: <10.000µs 📉 -74.8%) vs baseline: +3.8% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.8% ✅ title_noaspectTime: ✅ 0.501µs (SLO: <10.000µs 📉 -95.0%) vs baseline: ~same Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.7% ✅ translate_aspectTime: ✅ 3.254µs (SLO: <10.000µs 📉 -67.5%) vs baseline: -3.3% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.8% ✅ translate_noaspectTime: ✅ 1.037µs (SLO: <10.000µs 📉 -89.6%) vs baseline: ~same Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.7% ✅ upper_aspectTime: ✅ 2.285µs (SLO: <10.000µs 📉 -77.1%) vs baseline: +1.0% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.7% ✅ upper_noaspectTime: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.7% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.8% 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 26/26✅ appsecTime: ✅ 20.414ms (SLO: <22.300ms -8.5%) vs baseline: -0.6% Memory: ✅ 64.428MB (SLO: <66.000MB -2.4%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.348ms (SLO: <1.450ms -7.1%) vs baseline: +0.6% Memory: ✅ 63.512MB (SLO: <66.000MB -3.8%) vs baseline: +4.8% ✅ iastTime: ✅ 20.472ms (SLO: <22.250ms -8.0%) vs baseline: -0.3% Memory: ✅ 64.365MB (SLO: <66.000MB -2.5%) vs baseline: +4.7% ✅ profilerTime: ✅ 15.287ms (SLO: <16.550ms -7.6%) vs baseline: +0.2% Memory: ✅ 52.927MB (SLO: <53.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 26.085ms (SLO: <28.200ms -7.5%) vs baseline: -0.3% Memory: ✅ 66.601MB (SLO: <68.500MB -2.8%) vs baseline: +4.9% ✅ tracerTime: ✅ 20.473ms (SLO: <21.750ms -5.9%) vs baseline: ~same Memory: ✅ 64.409MB (SLO: <66.000MB -2.4%) vs baseline: +4.9% ✅ tracer-and-profilerTime: ✅ 22.109ms (SLO: <23.500ms -5.9%) vs baseline: +0.2% Memory: ✅ 65.726MB (SLO: <67.000MB 🟡 -1.9%) vs baseline: +4.9% ✅ tracer-dont-create-db-spansTime: ✅ 19.327ms (SLO: <21.500ms 📉 -10.1%) vs baseline: +0.1% Memory: ✅ 64.409MB (SLO: <66.000MB -2.4%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 20.536ms (SLO: <21.750ms -5.6%) vs baseline: +0.5% Memory: ✅ 65.588MB (SLO: <66.000MB 🟡 -0.6%) vs baseline: +4.6% ✅ tracer-no-cachesTime: ✅ 18.459ms (SLO: <19.650ms -6.1%) vs baseline: ~same Memory: ✅ 64.428MB (SLO: <66.000MB -2.4%) vs baseline: +4.8% ✅ tracer-no-databasesTime: ✅ 18.798ms (SLO: <20.100ms -6.5%) vs baseline: ~same Memory: ✅ 64.468MB (SLO: <66.000MB -2.3%) vs baseline: +4.9% ✅ tracer-no-middlewareTime: ✅ 20.143ms (SLO: <21.500ms -6.3%) vs baseline: -0.3% Memory: ✅ 64.448MB (SLO: <66.000MB -2.4%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.295ms (SLO: <22.000ms -7.8%) vs baseline: ~same Memory: ✅ 64.409MB (SLO: <66.000MB -2.4%) vs baseline: +4.8% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.027ms (SLO: <19.850ms -9.2%) vs baseline: ~same Memory: ✅ 64.487MB (SLO: <65.500MB 🟡 -1.5%) vs baseline: +5.0% ✅ errortracking-enabled-userTime: ✅ 18.068ms (SLO: <19.400ms -6.9%) vs baseline: ~same Memory: ✅ 64.428MB (SLO: <65.500MB 🟡 -1.6%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 18.009ms (SLO: <19.450ms -7.4%) vs baseline: -0.3% Memory: ✅ 64.419MB (SLO: <65.500MB 🟡 -1.7%) vs baseline: +4.9% 🟡 flasksimple - 17/17✅ appsec-getTime: ✅ 4.585ms (SLO: <4.750ms -3.5%) vs baseline: +0.4% Memory: ✅ 62.325MB (SLO: <64.500MB -3.4%) vs baseline: +4.9% ✅ appsec-postTime: ✅ 6.574ms (SLO: <6.750ms -2.6%) vs baseline: +0.3% Memory: ✅ 62.344MB (SLO: <64.500MB -3.3%) vs baseline: +5.1% ✅ appsec-telemetryTime: ✅ 4.581ms (SLO: <4.750ms -3.6%) vs baseline: ~same Memory: ✅ 62.246MB (SLO: <64.500MB -3.5%) vs baseline: +4.8% ✅ debuggerTime: ✅ 1.856ms (SLO: <2.000ms -7.2%) vs baseline: ~same Memory: ✅ 44.689MB (SLO: <45.000MB 🟡 -0.7%) vs baseline: +4.8% ✅ iast-getTime: ✅ 1.858ms (SLO: <2.000ms -7.1%) vs baseline: +0.3% Memory: ✅ 41.602MB (SLO: <49.000MB 📉 -15.1%) vs baseline: +4.9% ✅ profilerTime: ✅ 1.914ms (SLO: <2.100ms -8.9%) vs baseline: ~same Memory: ✅ 44.296MB (SLO: <46.500MB -4.7%) vs baseline: +4.7% ✅ tracerTime: ✅ 3.372ms (SLO: <3.650ms -7.6%) vs baseline: ~same Memory: ✅ 51.393MB (SLO: <53.500MB -3.9%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 3.376ms (SLO: <3.650ms -7.5%) vs baseline: +0.2% Memory: ✅ 52.593MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +5.0% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.941ms (SLO: <4.200ms -6.2%) vs baseline: +0.1% Memory: ✅ 62.492MB (SLO: <66.000MB -5.3%) vs baseline: +4.9% ✅ iast-enabledTime: ✅ 2.447ms (SLO: <2.800ms 📉 -12.6%) vs baseline: +0.3% Memory: ✅ 58.105MB (SLO: <59.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 2.080ms (SLO: <2.250ms -7.6%) vs baseline: ~same Memory: ✅ 51.205MB (SLO: <53.500MB -4.3%) vs baseline: +4.8% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 45.402ms (SLO: <47.150ms -3.7%) vs baseline: +0.5% Memory: ✅ 44.443MB (SLO: <46.500MB -4.4%) vs baseline: +5.0% ✅ add-metricsTime: ✅ 321.685ms (SLO: <344.800ms -6.7%) vs baseline: +1.1% Memory: ✅ 552.571MB (SLO: <562.000MB 🟡 -1.7%) vs baseline: +4.6% ✅ add-tagsTime: ✅ 294.703ms (SLO: <314.000ms -6.1%) vs baseline: +1.2% Memory: ✅ 553.845MB (SLO: <563.500MB 🟡 -1.7%) vs baseline: +4.6% ✅ get-contextTime: ✅ 82.494ms (SLO: <92.350ms 📉 -10.7%) vs baseline: ~same Memory: ✅ 39.615MB (SLO: <46.500MB 📉 -14.8%) vs baseline: +4.9% ✅ is-recordingTime: ✅ 43.722ms (SLO: <44.500ms 🟡 -1.7%) vs baseline: +1.8% Memory: ✅ 43.940MB (SLO: <46.500MB -5.5%) vs baseline: +4.9% ✅ record-exceptionTime: ✅ 62.040ms (SLO: <67.650ms -8.3%) vs baseline: +0.4% Memory: ✅ 39.923MB (SLO: <46.500MB 📉 -14.1%) vs baseline: +4.8% ✅ set-statusTime: ✅ 48.957ms (SLO: <50.400ms -2.9%) vs baseline: ~same Memory: ✅ 43.896MB (SLO: <46.500MB -5.6%) vs baseline: +4.9% ✅ startTime: ✅ 42.231ms (SLO: <43.450ms -2.8%) vs baseline: -0.5% Memory: ✅ 43.961MB (SLO: <46.500MB -5.5%) vs baseline: +5.0% ✅ start-finishTime: ✅ 83.661ms (SLO: <88.000ms -4.9%) vs baseline: +0.6% Memory: ✅ 33.817MB (SLO: <46.500MB 📉 -27.3%) vs baseline: +5.0% ✅ start-finish-telemetryTime: ✅ 86.161ms (SLO: <89.000ms -3.2%) vs baseline: +1.6% Memory: ✅ 33.797MB (SLO: <46.500MB 📉 -27.3%) vs baseline: +4.8% ✅ update-nameTime: ✅ 44.866ms (SLO: <45.150ms 🟡 -0.6%) vs baseline: +1.8% Memory: ✅ 44.251MB (SLO: <46.500MB -4.8%) vs baseline: +5.0%
|
7c5c7da
to
a19f0d7
Compare
Following #14513 that PR introduces a potencial conflict when a application shutdown exiting with a bad status code. the traceback suggests the vector’s internal state is invalid so the crash happens when constructing an iterator. I'm adding extra validations and a safe shutting down
NOTE: We tryied with a mutex or shared_mutex but that approach creates conflicts with gevent in IAST_STANDALONE tests
Checklist
Reviewer Checklist