-
Notifications
You must be signed in to change notification settings - Fork 461
ci: consistently use httpbin instead of httpbin-local #14856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Out of curiosity, where httpbin_local was used before this PR ?
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 246 ± 5 ms. The average import time from base is: 251 ± 6 ms. The import time difference between this PR and base is: -5.3 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate brettlangdon/httpbin (04f5e61) with baseline main (8235d03) 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.469ms (SLO: <22.300ms -8.2%) vs baseline: ~same Memory: ✅ 65.410MB (SLO: <67.000MB -2.4%) vs baseline: +4.7% ✅ exception-replay-enabledTime: ✅ 1.347ms (SLO: <1.450ms -7.1%) vs baseline: -0.2% Memory: ✅ 64.671MB (SLO: <67.000MB -3.5%) vs baseline: +5.2% ✅ iastTime: ✅ 20.436ms (SLO: <22.250ms -8.2%) vs baseline: -0.4% Memory: ✅ 65.503MB (SLO: <67.000MB -2.2%) vs baseline: +4.9% ✅ profilerTime: ✅ 15.312ms (SLO: <16.550ms -7.5%) vs baseline: +0.6% Memory: ✅ 53.785MB (SLO: <54.500MB 🟡 -1.3%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 20.561ms (SLO: <21.750ms -5.5%) vs baseline: -0.2% Memory: ✅ 65.413MB (SLO: <67.000MB -2.4%) vs baseline: +4.8% ✅ span-code-originTime: ✅ 26.210ms (SLO: <28.200ms -7.1%) vs baseline: +0.3% Memory: ✅ 67.688MB (SLO: <69.500MB -2.6%) vs baseline: +3.1% ✅ tracerTime: ✅ 20.497ms (SLO: <21.750ms -5.8%) vs baseline: ~same Memory: ✅ 65.410MB (SLO: <67.000MB -2.4%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 22.076ms (SLO: <23.500ms -6.1%) vs baseline: ~same Memory: ✅ 66.633MB (SLO: <67.500MB 🟡 -1.3%) vs baseline: +4.9% ✅ tracer-dont-create-db-spansTime: ✅ 19.361ms (SLO: <21.500ms -9.9%) vs baseline: -0.2% Memory: ✅ 65.417MB (SLO: <66.000MB 🟡 -0.9%) vs baseline: +4.8% ✅ tracer-minimalTime: ✅ 16.590ms (SLO: <17.500ms -5.2%) vs baseline: -0.3% Memory: ✅ 65.400MB (SLO: <66.000MB 🟡 -0.9%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 20.511ms (SLO: <21.750ms -5.7%) vs baseline: ~same Memory: ✅ 71.429MB (SLO: <72.500MB 🟡 -1.5%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 18.487ms (SLO: <19.650ms -5.9%) vs baseline: +0.2% Memory: ✅ 65.456MB (SLO: <67.000MB -2.3%) vs baseline: +5.0% ✅ tracer-no-databasesTime: ✅ 18.751ms (SLO: <20.100ms -6.7%) vs baseline: +0.2% Memory: ✅ 65.090MB (SLO: <67.000MB -2.9%) vs baseline: +4.3% ✅ tracer-no-middlewareTime: ✅ 20.192ms (SLO: <21.500ms -6.1%) vs baseline: ~same Memory: ✅ 65.452MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.340ms (SLO: <22.000ms -7.5%) vs baseline: -0.2% Memory: ✅ 65.396MB (SLO: <67.000MB -2.4%) vs baseline: +4.6% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.033ms (SLO: <19.850ms -9.2%) vs baseline: -0.5% Memory: ✅ 65.294MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.019ms (SLO: <19.400ms -7.1%) vs baseline: ~same Memory: ✅ 65.195MB (SLO: <66.500MB 🟡 -2.0%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 18.038ms (SLO: <19.450ms -7.3%) vs baseline: -0.5% Memory: ✅ 65.235MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.8% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.578ms (SLO: <4.750ms -3.6%) vs baseline: -0.4% Memory: ✅ 61.971MB (SLO: <65.000MB -4.7%) vs baseline: +5.0% ✅ appsec-postTime: ✅ 6.599ms (SLO: <6.750ms -2.2%) vs baseline: +0.5% Memory: ✅ 61.951MB (SLO: <65.000MB -4.7%) vs baseline: +4.5% ✅ appsec-telemetryTime: ✅ 4.570ms (SLO: <4.750ms -3.8%) vs baseline: +0.3% Memory: ✅ 62.030MB (SLO: <65.000MB -4.6%) vs baseline: +5.0% ✅ debuggerTime: ✅ 1.859ms (SLO: <2.000ms -7.0%) vs baseline: ~same Memory: ✅ 45.397MB (SLO: <47.000MB -3.4%) vs baseline: +4.9% ✅ iast-getTime: ✅ 1.865ms (SLO: <2.000ms -6.8%) vs baseline: -0.2% Memory: ✅ 42.408MB (SLO: <49.000MB 📉 -13.5%) vs baseline: +5.1% ✅ profilerTime: ✅ 1.913ms (SLO: <2.100ms -8.9%) vs baseline: -0.1% Memory: ✅ 46.439MB (SLO: <47.000MB 🟡 -1.2%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 3.386ms (SLO: <3.650ms -7.2%) vs baseline: -0.1% Memory: ✅ 52.199MB (SLO: <53.500MB -2.4%) vs baseline: +4.8% ✅ tracerTime: ✅ 3.381ms (SLO: <3.650ms -7.4%) vs baseline: ~same Memory: ✅ 52.180MB (SLO: <53.500MB -2.5%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 3.369ms (SLO: <3.650ms -7.7%) vs baseline: ~same Memory: ✅ 58.296MB (SLO: <60.000MB -2.8%) vs baseline: +4.8% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 42.395ms (SLO: <47.150ms 📉 -10.1%) vs baseline: -0.1% Memory: ✅ 44.427MB (SLO: <47.000MB -5.5%) vs baseline: +4.7% ✅ add-metricsTime: ✅ 320.584ms (SLO: <344.800ms -7.0%) vs baseline: +0.7% Memory: ✅ 594.899MB (SLO: <600.000MB 🟡 -0.9%) vs baseline: +4.7% ✅ add-tagsTime: ✅ 290.732ms (SLO: <314.000ms -7.4%) vs baseline: +0.4% Memory: ✅ 596.431MB (SLO: <600.000MB 🟡 -0.6%) vs baseline: +4.8% ✅ get-contextTime: ✅ 80.926ms (SLO: <92.350ms 📉 -12.4%) vs baseline: ~same Memory: ✅ 39.976MB (SLO: <46.500MB 📉 -14.0%) vs baseline: +5.0% ✅ is-recordingTime: ✅ 39.035ms (SLO: <44.500ms 📉 -12.3%) vs baseline: -0.6% Memory: ✅ 43.937MB (SLO: <47.500MB -7.5%) vs baseline: +4.9% ✅ record-exceptionTime: ✅ 59.851ms (SLO: <67.650ms 📉 -11.5%) vs baseline: +2.0% Memory: ✅ 40.285MB (SLO: <47.000MB 📉 -14.3%) vs baseline: +4.9% ✅ set-statusTime: ✅ 44.737ms (SLO: <50.400ms 📉 -11.2%) vs baseline: -0.8% Memory: ✅ 43.950MB (SLO: <47.000MB -6.5%) vs baseline: +5.0% ✅ startTime: ✅ 38.104ms (SLO: <43.450ms 📉 -12.3%) vs baseline: -0.2% Memory: ✅ 43.945MB (SLO: <47.000MB -6.5%) vs baseline: +4.8% ✅ start-finishTime: ✅ 82.653ms (SLO: <88.000ms -6.1%) vs baseline: -0.2% Memory: ✅ 34.544MB (SLO: <46.500MB 📉 -25.7%) vs baseline: +5.0% ✅ start-finish-telemetryTime: ✅ 84.312ms (SLO: <89.000ms -5.3%) vs baseline: +0.1% Memory: ✅ 34.505MB (SLO: <46.500MB 📉 -25.8%) vs baseline: +4.7% ✅ update-nameTime: ✅ 40.156ms (SLO: <45.150ms 📉 -11.1%) vs baseline: -0.8% Memory: ✅ 44.234MB (SLO: <47.000MB -5.9%) vs baseline: +5.0% 🟡 span - 26/26✅ add-eventTime: ✅ 20.576ms (SLO: <22.500ms -8.6%) vs baseline: +0.8% Memory: ✅ 50.395MB (SLO: <53.000MB -4.9%) vs baseline: +5.0% ✅ add-metricsTime: ✅ 91.411ms (SLO: <93.500ms -2.2%) vs baseline: +1.0% Memory: ✅ 660.931MB (SLO: <961.000MB 📉 -31.2%) vs baseline: +4.8% ✅ add-tagsTime: ✅ 148.343ms (SLO: <155.000ms -4.3%) vs baseline: +0.7% Memory: ✅ 661.673MB (SLO: <962.500MB 📉 -31.3%) vs baseline: +4.8% ✅ get-contextTime: ✅ 19.901ms (SLO: <20.500ms -2.9%) vs baseline: +3.3% Memory: ✅ 49.173MB (SLO: <53.000MB -7.2%) vs baseline: +4.9% ✅ is-recordingTime: ✅ 19.534ms (SLO: <20.500ms -4.7%) vs baseline: +0.5% Memory: ✅ 49.152MB (SLO: <53.000MB -7.3%) vs baseline: +4.9% ✅ record-exceptionTime: ✅ 38.474ms (SLO: <40.000ms -3.8%) vs baseline: +0.4% Memory: ✅ 42.768MB (SLO: <53.000MB 📉 -19.3%) vs baseline: +4.9% ✅ set-statusTime: ✅ 21.351ms (SLO: <22.000ms -3.0%) vs baseline: +1.5% Memory: ✅ 49.152MB (SLO: <53.000MB -7.3%) vs baseline: +4.8% ✅ startTime: ✅ 19.585ms (SLO: <20.500ms -4.5%) vs baseline: +2.5% Memory: ✅ 49.190MB (SLO: <53.000MB -7.2%) vs baseline: +4.7% ✅ start-finishTime: ✅ 51.948ms (SLO: <52.500ms 🟡 -1.1%) vs baseline: +1.2% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.7% ✅ start-finish-telemetryTime: ✅ 52.772ms (SLO: <54.500ms -3.2%) vs baseline: +0.3% Memory: ✅ 32.047MB (SLO: <34.000MB -5.7%) vs baseline: +4.7% ✅ start-finish-traceid128Time: ✅ 54.734ms (SLO: <56.000ms -2.3%) vs baseline: ~same Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.0% ✅ start-traceid128Time: ✅ 19.448ms (SLO: <22.500ms 📉 -13.6%) vs baseline: +0.3% Memory: ✅ 49.089MB (SLO: <53.000MB -7.4%) vs baseline: +4.7% ✅ update-nameTime: ✅ 20.469ms (SLO: <22.000ms -7.0%) vs baseline: +2.7% Memory: ✅ 49.802MB (SLO: <53.000MB -6.0%) vs baseline: +4.9%
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think some tests will probably have to change to match.
docker-compose was always |
Apparently we cannot use |
Description
Inconsistency between CI and local development makes spinning up and getting correct hostnames and etc correct challenging.
Testing
Risks
Additional Notes