Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APM SDK Terminology #3819

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

APM SDK Terminology #3819

wants to merge 1 commit into from

Conversation

brett0000FF
Copy link
Contributor

What does this PR do?

  • Updates single-sourced public documentation to replace "tracer" and "tracing library" with "APM SDK".

Motivation:

DataDog/documentation#24255

Additional Notes:

Please don't merge into release until the documentation PR linked above is merged.

How to test the change?

Unsure? Have a question? Request a review!

@brett0000FF brett0000FF requested review from a team as code owners July 31, 2024 15:34
@github-actions github-actions bot added the docs Involves documentation label Jul 31, 2024
@ivoanjo
Copy link
Member

ivoanjo commented Jul 31, 2024

I guess:

should also be updated to reflect this once it's ready to go?

@pr-commenter
Copy link

pr-commenter bot commented Jul 31, 2024

Benchmarks

Benchmark execution time: 2024-07-31 16:03:12

Comparing candidate commit 1705fec in PR branch brett0000FF/dd-sdks with baseline commit 47f12db in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Copy link

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, I'll let you merge once the related PR is reviewed (editorial review)

@brett0000FF
Copy link
Contributor Author

should also be updated to reflect this once it's ready to go?

@ivoanjo - Yeah, I talked about this with @tushar-datadog . I think for consistency's sake, we should keep the terminology consistent wherever possible.

@aliciascott
Copy link

Hey @brett0000FF is this still one you are planning on merging ? Just noticed it was in my stale queue but also looks like there is a merge conflict now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Involves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants