fix failing system tests

[wconti27]

What does this PR do?

System tests job is currently failing because the runner expects certain AWS env variables to be set. However, the use of ++docker, which runs the runner in a docker container, was not covered by the latest commit adding these system tests., and only the case that the runner is on the local machine was covered. Run the failing scenario using a non-containerized runner until the case is fixed within the system tests repo.

Motivation:

Change log entry

Additional Notes:

How to test the change?

[Strech]

Just to leave some mark and not forget to remove it, should we puts some echo message about it?

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-10-24 18:02:34

Comparing candidate commit 4840d30 in PR branch conti/fix-system-tests with baseline commit 06e050b in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

• 🟩 throughput [+0.615op/s; +0.624op/s] or [+9.993%; +10.146%]

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (06e050b) to head (4840d30).
Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4026      +/-   ##
==========================================
- Coverage   97.86%   97.86%   -0.01%     
==========================================
  Files        1319     1319              
  Lines       79322    79322              
  Branches     3934     3934              
==========================================
- Hits        77628    77627       -1     
- Misses       1694     1695       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vpellan]

That would mean that system-tests would not run on the main system-tests branch but on conti/set-aws-env-on-docker-runner branch. If that's intended you can replace ST_REF: main at line 14 but this should not be merged in dd-trace-rb master, as this is only a way to use a system-tests branch (while waiting for it to be merged in main) on your branch/PR and this should always be set to main on dd-trace-rb masterbranch

Code changed into different direction