DEBUG-2334 remaining dynamic instrumentation code #4098
+1,227
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
spec/datadog/di/contrib/active_record/serializer_active_record_spec.rb
Outdated
Show resolved
Hide resolved
BenchmarksBenchmark execution time: 2024-11-13 17:07:56 Comparing candidate commit 210b795 in PR branch Found 0 performance improvements and 4 performance regressions! Performance is the same for 25 metrics, 2 unstable metrics. scenario:library - Gem loading
scenario:method instrumentation
scenario:profiler - Major GC runs (profiling disabled)
scenario:profiler - sample timeline=false
|
p-datadog
force-pushed
the
di-rest-2
branch
2 times, most recently
from
b7e93a0
to
288d1d8
Compare
p-datadog
force-pushed
the
di-rest-2
branch
4 times, most recently
from
5408cbb
to
79e1ff8
Compare
…rtual' into HEAD * di-end-instrumentation: test else and end of a conditional also handle end lines of blocks via b_return trace point check line probes on non-executable lines DEBUG-2334 Use :return trace point to target 'end' line of methods with line probes Deny `rubygems-update` injection * di-unused-stubs: DEBUG-2334 remove unused method stubs from DI test suite * di-virtual: DEBUG-2334 repair instrumentation of virtual and later-defined methods
…bes are parsed and installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation:
Initial DI implementation in Ruby
Change log entry
Dynamic instrumentation is now available in Ruby. Currently only log probes are implemented, but they can be set on both methods and lines.
Additional Notes:
Replaces #4063
How to test the change?