Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove racc gem from 3.3 and 3.4 appraisal files #4251

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

sarahchen6
Copy link
Contributor

What does this PR do?
Remove racc gem from 3.3 and 3.4 appraisal files, since rmosolgo/graphql-ruby#4650 is resolved.

Motivation:
Update appraisal files.

Change log entry
No.

Additional Notes:
N/A

How to test the change?
Green CI.

@sarahchen6 sarahchen6 requested a review from a team as a code owner January 2, 2025 15:58
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 2, 2025

Datadog Report

Branch report: sarahchen6/update-3.3-3.4-appraisal
Commit report: 2049745
Test service: dd-trace-rb

✅ 0 Failed, 22127 Passed, 1476 Skipped, 5m 43.91s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 2, 2025

Benchmarks

Benchmark execution time: 2025-01-03 10:31:04

Comparing candidate commit 2049745 in PR branch sarahchen6/update-3.3-3.4-appraisal with baseline commit b1400d5 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.75%. Comparing base (b1400d5) to head (2049745).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4251      +/-   ##
==========================================
- Coverage   97.76%   97.75%   -0.01%     
==========================================
  Files        1353     1353              
  Lines       82392    82393       +1     
  Branches     4224     4224              
==========================================
- Hits        80550    80546       -4     
- Misses       1842     1847       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sarahchen6 sarahchen6 merged commit 953b30e into master Jan 3, 2025
347 checks passed
@sarahchen6 sarahchen6 deleted the sarahchen6/update-3.3-3.4-appraisal branch January 3, 2025 13:02
@github-actions github-actions bot added this to the 2.9.0 milestone Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants