DEBUG-3251 dependency inject logger into DI component #4262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-datadog
force-pushed
the
di-inject-logger
branch
from
72affca to
1ab4ce8
Compare
p-datadog
force-pushed
the
di-inject-logger
branch
from
1ab4ce8 to
0c085e6
Compare
Datadog ReportBranch report: ✅ 0 Failed, 22114 Passed, 1476 Skipped, 5m 33.05s Total Time |
BenchmarksBenchmark execution time: 2025-01-08 05:33:22 Comparing candidate commit 6fb789e in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:profiler - Allocations ()
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4262 +/- ##
==========================================
- Coverage 97.73% 97.73% -0.01%
==========================================
Files 1352 1352
Lines 82409 82419 +10
Branches 4224 4224
==========================================
+ Hits 80545 80551 +6
- Misses 1864 1868 +4 ☔ View full report in Codecov by Sentry. |
p-datadog
pushed a commit
to p-datadog/dd-trace-rb
that referenced
this pull request
Jan 9, 2025
* master: DEBUG-3210 DI: change logging to be appropriate for customer inspection (DataDog#4266) Report timing information if try_wait_until times out (DataDog#4265) Move simplecov patch to an overlay in our tree instead of using a forked simplecov repo (DataDog#4263) DEBUG-3251 dependency inject logger into DI component (DataDog#4262) DEBUG-3182 move Rails utils to core (DataDog#4261) add supported versions workflow (DataDog#4210) DEBUG-3305 remove dependency on benchmark (DataDog#4259) Fix case & grammar in issue template (DataDog#4244) [🤖] Update Latest Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/12614773826
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Alters DI component initialization to pass the logger into DI as a parameter rather than DI reading it out of Datadog module.
Motivation:
Logging should be passed into DI in one way.
Additionally, #4230 makes changes to how the logging is handled within DI, this PR makes the test suite log to mocks in several places and these places would need to be adjusted in addition to the other code in #4230.
Change log entry
None
Additional Notes:
How to test the change?