-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report timing information if try_wait_until times out #4265
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 24606 Passed, 1515 Skipped, 5m 29.35s Total Time New Flaky Tests (1)
|
BenchmarksBenchmark execution time: 2025-01-08 14:57:40 Comparing candidate commit f2ad94f in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:tracing - Propagation - Trace Context
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
* master: DEBUG-3210 DI: change logging to be appropriate for customer inspection (DataDog#4266) Report timing information if try_wait_until times out (DataDog#4265) Move simplecov patch to an overlay in our tree instead of using a forked simplecov repo (DataDog#4263) DEBUG-3251 dependency inject logger into DI component (DataDog#4262) DEBUG-3182 move Rails utils to core (DataDog#4261) add supported versions workflow (DataDog#4210) DEBUG-3305 remove dependency on benchmark (DataDog#4259) Fix case & grammar in issue template (DataDog#4244) [🤖] Update Latest Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/12614773826
What does this PR do?
Adds timing information to the exception message if
try_wait_until
fails.Motivation:
There are flaky tests that fail with this timeout but do not provide much information to determine whether a longer wait time is appropriate (example: https://app.circleci.com/pipelines/github/DataDog/dd-trace-rb/18420/workflows/05d20861-e600-4a0a-a1a1-5d39e964a755/jobs/648349)
Change log entry
None
Additional Notes:
Example message produced:
How to test the change?
Not applicable