Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Span and SpanOperation pretty print #4273

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Jan 9, 2025

What does this PR do?

Motivation:

Change log entry

Additional Notes:

How to test the change?

Copy link

github-actions bot commented Jan 9, 2025

👋 Hey @marcotc, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-01-09 23:18:37 UTC

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 9, 2025

Datadog Report

Branch report: better-print
Commit report: 852c92d
Test service: dd-trace-rb

✅ 0 Failed, 22117 Passed, 1476 Skipped, 5m 51.02s Total Time

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 84.70588% with 13 lines in your changes missing coverage. Please review.

Project coverage is 97.73%. Comparing base (aff0f7c) to head (852c92d).

Files with missing lines Patch % Lines
lib/datadog/tracing/span_event.rb 45.45% 6 Missing ⚠️
lib/datadog/tracing/span_link.rb 57.14% 6 Missing ⚠️
lib/datadog/tracing/span.rb 97.95% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4273      +/-   ##
==========================================
- Coverage   97.73%   97.73%   -0.01%     
==========================================
  Files        1354     1354              
  Lines       82449    82484      +35     
  Branches     4236     4249      +13     
==========================================
+ Hits        80584    80614      +30     
- Misses       1865     1870       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 9, 2025

Benchmarks

Benchmark execution time: 2025-01-09 23:31:56

Comparing candidate commit 852c92d in PR branch better-print with baseline commit aff0f7c in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:profiler - profiler gc

  • 🟩 throughput [+16003.055op/s; +16523.006op/s] or [+5.594%; +5.776%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants