Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align simplecov version usage #4278

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Jan 10, 2025

What does this PR do?

Align simplecov version usage

Motivation:

From: #4263

Gemfile definition for simplecov without constraint causing 0.21.2 and 0.22.0 installed across different groups.

Change log entry
None.

@TonyCTHsu TonyCTHsu added the dev/ci Involves CircleCI, GitHub Actions, or GitLab label Jan 10, 2025
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner January 10, 2025 15:29
Copy link

github-actions bot commented Jan 10, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-01-10 15:29:48 UTC

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 10, 2025

Datadog Report

Branch report: tonycthsu/align-simplecov-version
Commit report: 7a50b66
Test service: dd-trace-rb

✅ 0 Failed, 22124 Passed, 1477 Skipped, 5m 27.42s Total Time

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (7c02a1c) to head (7a50b66).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4278   +/-   ##
=======================================
  Coverage   97.72%   97.72%           
=======================================
  Files        1354     1354           
  Lines       82419    82419           
  Branches     4220     4220           
=======================================
+ Hits        80540    80544    +4     
+ Misses       1879     1875    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 10, 2025

Benchmarks

Benchmark execution time: 2025-01-10 16:00:42

Comparing candidate commit 7a50b66 in PR branch tonycthsu/align-simplecov-version with baseline commit 7c02a1c in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@TonyCTHsu TonyCTHsu merged commit 12add3a into master Jan 10, 2025
388 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/align-simplecov-version branch January 10, 2025 16:03
@github-actions github-actions bot added this to the 2.9.0 milestone Jan 10, 2025
@ivoanjo ivoanjo changed the title Align simplcov version usage Align simplecov version usage Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/ci Involves CircleCI, GitHub Actions, or GitLab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants