Skip to content

Conversation

vpellan
Copy link
Contributor

@vpellan vpellan commented Oct 14, 2025

What does this PR do?

It only show the diff between base branch and current branch for typing stats

Motivation:

It will add more value to the typing stats comment

Change log entry

None.

Additional Notes:

How to test the change?

When it will be ready, it should display a comment saying there is no changes. You'll be able to see the changes through the edit history of that comment

@github-actions github-actions bot added the appsec Application Security monitoring product label Oct 14, 2025
@vpellan vpellan force-pushed the vpellan/typing-stats-diff branch from 2dce7de to f591994 Compare October 14, 2025 11:36
@pr-commenter
Copy link

pr-commenter bot commented Oct 14, 2025

Benchmarks

Benchmark execution time: 2025-10-17 08:45:30

Comparing candidate commit 73cae16 in PR branch vpellan/typing-stats-diff with baseline commit c5e3981 in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 42 metrics, 2 unstable metrics.

scenario:error - error tracking, with_error=false - user code only

  • 🟩 throughput [+616.043op/s; +664.721op/s] or [+5.262%; +5.678%]

scenario:error - error tracking, with_error=true - all

  • 🟩 throughput [+561.794op/s; +583.443op/s] or [+8.580%; +8.911%]

@vpellan vpellan force-pushed the vpellan/typing-stats-diff branch 3 times, most recently from 7b79609 to ac71446 Compare October 14, 2025 16:01
Copy link

github-actions bot commented Oct 14, 2025

Typing analysis

This PR does not change typing compared to the base branch.

@vpellan vpellan force-pushed the vpellan/typing-stats-diff branch 2 times, most recently from 7d3551d to 3ccc82a Compare October 14, 2025 16:04
Copy link

datadog-official bot commented Oct 14, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 98.59% (+0.03%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 73cae16 | Docs | Was this helpful? Give us feedback!

@vpellan vpellan force-pushed the vpellan/typing-stats-diff branch 5 times, most recently from 8db346a to dc06238 Compare October 16, 2025 11:28
@vpellan vpellan force-pushed the vpellan/typing-stats-diff branch from d2428ef to 33b81f2 Compare October 16, 2025 15:50
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Oct 16, 2025
@vpellan vpellan force-pushed the vpellan/typing-stats-diff branch from 33b81f2 to d6ddb4d Compare October 16, 2025 15:57
@vpellan vpellan force-pushed the vpellan/typing-stats-diff branch from d6ddb4d to 3abd1b6 Compare October 16, 2025 16:11
@vpellan vpellan marked this pull request as ready for review October 16, 2025 16:25
@vpellan vpellan requested review from a team as code owners October 16, 2025 16:25
Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! It makes it so clear what type changes happened!

@vpellan vpellan force-pushed the vpellan/typing-stats-diff branch from 7a91566 to f4d697c Compare October 17, 2025 08:11
@vpellan vpellan force-pushed the vpellan/typing-stats-diff branch 2 times, most recently from 5ad214d to 73cae16 Compare October 17, 2025 08:15
Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼 Well done!

@vpellan vpellan merged commit 2f20b9a into master Oct 17, 2025
692 of 701 checks passed
@vpellan vpellan deleted the vpellan/typing-stats-diff branch October 17, 2025 10:46
@github-actions github-actions bot added this to the 2.23.0 milestone Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

appsec Application Security monitoring product dev/github Github repository maintenance and automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants