Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Sprockets version in CI #836

Merged
merged 3 commits into from
Oct 9, 2019
Merged

Pin Sprockets version in CI #836

merged 3 commits into from
Oct 9, 2019

Conversation

delner
Copy link
Contributor

@delner delner commented Oct 9, 2019

Tests in CI started breaking with Sprockets expecting a manifest JS file:

18: from /app/test/contrib/rails/apps/rails5.rb:8:in `<top (required)>'
...
1: from /usr/local/bundle/gems/railties-5.2.3/lib/rails/initializable.rb:32:in `instance_exec'
/usr/local/bundle/gems/sprockets-rails-3.2.1/lib/sprockets/railtie.rb:105:in `block in <class:Railtie>': Expected to find a manifest file in `app/assets/config/manifest.js` (Sprockets::Railtie::ManifestNeededError)
But did not, please create this file and use it to link any assets that need
to be rendered by your app:

Example:
  //= link_tree ../images
  //= link_directory ../javascripts .js
  //= link_directory ../stylesheets .css
and restart your server

Since we don't use or test sprockets, let's disable it in CI to prevent build failures.

@delner delner added the dev/testing Involves testing processes (e.g. RSpec) label Oct 9, 2019
@delner delner requested review from marcotc and a team October 9, 2019 09:23
@delner delner self-assigned this Oct 9, 2019
marcotc
marcotc previously approved these changes Oct 9, 2019
@delner
Copy link
Contributor Author

delner commented Oct 9, 2019

Opened a related issue here: rails/sprockets-rails#444

@marcotc marcotc changed the title Disable Sprockets in CI Pin Sprockets version in CI Oct 9, 2019
Copy link
Contributor Author

@delner delner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @marcotc; thanks for updating this!

@marcotc marcotc merged commit 18300bd into master Oct 9, 2019
@marcotc marcotc deleted the ci/disable_rails_sprockets branch October 9, 2019 10:11
@delner delner added this to the 0.29.0 milestone Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants