Describe histogram aggregates and percentile configs as comma-separated #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaj
approved these changes
Mar 21, 2019
|
thanks @chrisjseaton :) |
tebriel
added a commit
to tebriel/datadog-agent
that referenced
this pull request
Apr 12, 2019
Just like in: DataDog/docker-dd-agent#365, we got bitten by incorrect documentation around how to specify a custom list. So just like in 365, I'm updating the documentation to indicate that the fields must be comma separated, not space separated. Thanks!
|
FYI This is similarly incorrectly described over here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.
See #364
What does this PR do?
Updates the descriptions of the DD_HISTOGRAM_AGGREGATES and DD_HISTOGRAM_PERCENTILES environment variables to state they are comma-separated.
Motivation
What inspired you to submit this pull request?
I got bitten by this bug when adding the
sumaggregate.