Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: cecilia saixue watt <[email protected]>
  • Loading branch information
joelmarcotte and cswatt authored Dec 12, 2023
1 parent eede7f8 commit 64812a4
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 12 deletions.
4 changes: 2 additions & 2 deletions content/en/database_monitoring/setup_sql_server/azure.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ CREATE USER datadog FOR LOGIN datadog;
GRANT CONNECT ANY DATABASE to datadog;
GRANT VIEW SERVER STATE to datadog;
GRANT VIEW ANY DEFINITION to datadog;
-- If you intend on using monitoring log shipping (availably in agent v7.50+), proceed with the following:
-- To use Log Shipping Monitoring (available in Agent v7.50+), uncomment the next three lines:
-- USE msdb;
-- CREATE USER datadog FOR LOGIN datadog;
-- GRANT SELECT to datadog;
Expand All @@ -118,7 +118,7 @@ CREATE LOGIN datadog WITH PASSWORD = '<PASSWORD>';
CREATE USER datadog FOR LOGIN datadog;
GRANT VIEW SERVER STATE to datadog;
GRANT VIEW ANY DEFINITION to datadog;
-- If you intend on using monitoring log shipping (availably in agent v7.50+), proceed with the following:
-- To use Log Shipping Monitoring (available in Agent v7.50+), uncomment the next three lines:
-- USE msdb;
-- CREATE USER datadog FOR LOGIN datadog;
-- GRANT SELECT to datadog;
Expand Down
13 changes: 5 additions & 8 deletions content/en/database_monitoring/setup_sql_server/rds.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,10 @@ Database Monitoring provides deep visibility into your Microsoft SQL Server data

Do the following steps to enable Database Monitoring with your database:

- [Before you begin](#before-you-begin)
- [Configure the AWS integration](#configure-the-aws-integration)
- [Grant the Agent access](#grant-the-agent-access)
- [Install the Agent](#install-the-agent)
- [Example Agent Configurations](#example-agent-configurations)
- [Install the RDS integration](#install-the-rds-integration)
- [Further reading](#further-reading)
1. [Configure the AWS integration](#configure-the-aws-integration)
1. [Grant the Agent access](#grant-the-agent-access)
1. [Install the Agent](#install-the-agent)
1. [Install the RDS integration](#install-the-rds-integration)

## Before you begin

Expand All @@ -53,7 +50,7 @@ GO
--Set context to msdb database and create datadog user
USE [msdb];
CREATE USER datadog FOR LOGIN datadog;
-- If you intend on using log shipping monitoring (availably in agent v7.50), proceed with the following:
-- To use Log Shipping Monitoring (available in Agent v7.50+), uncomment the next line:
-- GRANT SELECT to datadog;
GO
--Switch back to master and grant datadog user server permissions
Expand Down
4 changes: 2 additions & 2 deletions content/en/database_monitoring/setup_sql_server/selfhosted.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ CREATE USER datadog FOR LOGIN datadog;
GRANT CONNECT ANY DATABASE to datadog;
GRANT VIEW SERVER STATE to datadog;
GRANT VIEW ANY DEFINITION to datadog;
-- If you intend on using monitoring log shipping (availably in agent v7.50+), proceed with the following:
-- To use Log Shipping Monitoring (available in Agent v7.50+), uncomment the next three lines:
-- USE msdb;
-- CREATE USER datadog FOR LOGIN datadog;
-- GRANT SELECT to datadog;
Expand All @@ -64,7 +64,7 @@ CREATE LOGIN datadog WITH PASSWORD = '<PASSWORD>';
CREATE USER datadog FOR LOGIN datadog;
GRANT VIEW SERVER STATE to datadog;
GRANT VIEW ANY DEFINITION to datadog;
-- If you intend on using monitoring log shipping (availably in agent v7.50+), proceed with the following:
-- To use Log Shipping Monitoring (available in Agent v7.50+), uncomment the next three lines:
-- USE msdb;
-- CREATE USER datadog FOR LOGIN datadog;
-- GRANT SELECT to datadog;
Expand Down

0 comments on commit 64812a4

Please sign in to comment.