Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM][Python] Clarify 2.x debug tracer behavior for dd-trace-py #20929

Merged
merged 5 commits into from
Dec 13, 2023

Conversation

wantsui
Copy link
Contributor

@wantsui wantsui commented Dec 6, 2023

What does this PR do? What is the motivation?

Clarify the root logger behavior for 2.x.

Code snippet provided by @emmettbutler !

Merge instructions

  • Please merge after reviewing

Additional notes

Copy link
Contributor

github-actions bot commented Dec 6, 2023

Preview links (active after the build_preview check completes)

Modified Files

@kayayarai kayayarai removed the request for review from brett0000FF December 7, 2023 15:48
@wantsui wantsui marked this pull request as ready for review December 12, 2023 19:53
@wantsui wantsui requested a review from a team as a code owner December 12, 2023 19:53
Copy link
Contributor

@cswatt cswatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny nits

content/en/tracing/troubleshooting/tracer_debug_logs.md Outdated Show resolved Hide resolved
content/en/tracing/troubleshooting/tracer_debug_logs.md Outdated Show resolved Hide resolved
Co-authored-by: cecilia saixue watt <[email protected]>
@kayayarai kayayarai merged commit 298e48d into master Dec 13, 2023
13 checks passed
@kayayarai kayayarai deleted the wantsui/2.x-debug-instructions branch December 13, 2023 15:42
MaelNamNam pushed a commit that referenced this pull request Jan 17, 2024
* clarify 2.x debug behavior

* Update content/en/tracing/troubleshooting/tracer_debug_logs.md

Co-authored-by: Kari Halsted <[email protected]>

* Apply suggestions from code review

Co-authored-by: cecilia saixue watt <[email protected]>

---------

Co-authored-by: Kari Halsted <[email protected]>
Co-authored-by: cecilia saixue watt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants