Add GitHub PRs to the Static Analysis integrations #20981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhgilbert
added
WORK IN PROGRESS
Preview links (active after the
|
markazerdd
requested changes
Dec 12, 2023
Co-authored-by: Mark Azer <[email protected]>
jhgilbert
removed
WORK IN PROGRESS
|
Should not be merged yet, but is ready for docs team review. |
drichards-87
approved these changes
Dec 13, 2023
jhgilbert
added
WORK IN PROGRESS
markazerdd
requested changes
Dec 21, 2023
Co-authored-by: Mark Azer <[email protected]>
jhgilbert
added
WORK IN PROGRESS
|
Had some feedback on this @markazerdd @jhgilbert From the user's POV, the content in the first and third sections below have a lot of overlap. We could put the prerequisite blurb under the "Configure a GitHub App" heading? For Step 4 of the "Subscribe to events", we check the "Pull Request review comment" box which is wrong. We need users to check the "Pull Request" box only. |
dastrong
requested changes
Jan 3, 2024
|
@dastrong Thanks for the feedback -- I think the user will be frustrated if they work through the prerequisite link and then have to revisit the same GitHub App to update it, so I rephrased that part to keep the user on the page instead. Let me know if this works better for you. CC @markazerdd |
markazerdd
approved these changes
Jan 4, 2024
alai97
reviewed
Jan 5, 2024
Co-authored-by: Austin Lai <[email protected]>
Co-authored-by: Austin Lai <[email protected]>
Co-authored-by: Austin Lai <[email protected]>
Co-authored-by: Austin Lai <[email protected]>
Co-authored-by: Austin Lai <[email protected]>
Co-authored-by: Austin Lai <[email protected]>
Co-authored-by: Austin Lai <[email protected]>
Co-authored-by: Austin Lai <[email protected]>
Co-authored-by: Austin Lai <[email protected]>
Co-authored-by: Austin Lai <[email protected]>
alai97
reviewed
Jan 5, 2024
MaelNamNam
pushed a commit
that referenced
this pull request
Jan 17, 2024
* Add GitHub PRs to the integrations * Update _index.md * Update content/en/continuous_integration/static_analysis/_index.md Co-authored-by: Mark Azer <[email protected]> * Update _index.md * Write feature overview for GitHub source code management * Sketch in content outline * Add page to the TOC * Add section on configuring a GitHub App * Add product shot * Update product screenshot * Flesh out GitHub App instructions * Finish first draft of instructions * Update content/en/static_analysis/github_source_code_management.md Co-authored-by: Mark Azer <[email protected]> * Update content/en/static_analysis/github_source_code_management.md Co-authored-by: Mark Azer <[email protected]> * Update content/en/static_analysis/github_source_code_management.md Co-authored-by: Mark Azer <[email protected]> * Update content/en/static_analysis/github_source_code_management.md Co-authored-by: Mark Azer <[email protected]> * Update content/en/static_analysis/github_source_code_management.md Co-authored-by: Mark Azer <[email protected]> * Integrate feedback * Rename file * Update URL * Integrate feedback * Update identifier * Update _index.md * Tweak instructions * Integrate feedback * Update content/en/static_analysis/github_pull_requests.md Co-authored-by: Austin Lai <[email protected]> * Update content/en/static_analysis/github_pull_requests.md Co-authored-by: Austin Lai <[email protected]> * Update content/en/static_analysis/github_pull_requests.md Co-authored-by: Austin Lai <[email protected]> * Update content/en/static_analysis/github_pull_requests.md Co-authored-by: Austin Lai <[email protected]> * Update content/en/static_analysis/github_pull_requests.md Co-authored-by: Austin Lai <[email protected]> * Update content/en/static_analysis/github_pull_requests.md Co-authored-by: Austin Lai <[email protected]> * Update content/en/static_analysis/github_pull_requests.md Co-authored-by: Austin Lai <[email protected]> * Update content/en/static_analysis/github_pull_requests.md Co-authored-by: Austin Lai <[email protected]> * Update content/en/static_analysis/github_pull_requests.md Co-authored-by: Austin Lai <[email protected]> * Update content/en/static_analysis/github_pull_requests.md Co-authored-by: Austin Lai <[email protected]> * Spacing Nit --------- Co-authored-by: Mark Azer <[email protected]> Co-authored-by: Austin Lai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
DOCS-5928, adds GitHub PRs to the integrations for Static Analysis.
Merge instructions
Additional notes