Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-9376 - update step functions install #26259

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cswatt
Copy link
Contributor

@cswatt cswatt commented Nov 12, 2024

What does this PR do? What is the motivation?

Merge instructions

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@cswatt cswatt requested review from a team as code owners November 12, 2024 22:33
Copy link
Contributor

Copy link
Contributor

@nine5two7 nine5two7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

5. Enter a filter name. You can choose to name it "empty filter" and leave the *Filter pattern* box blank.

<div class="alert alert-warning"> If you are using a different instrumentation method, such as Serverless Framework or datadog-ci, enabling autosubscription may create duplicated logs. To avoid this behavior, choose only one configuration method.</div>
2. Ensure you have deployed the [Datadog Lambda Forwarder][11], and that you are using v3.121.0+. You may need to [update your Forwarder][12]. As an alternative, you may also use [Amazon Data Firehose][16].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may = permission
might = possibility

From Google doc style guide:

may:
In general, reserve for official policy or legal considerations.
To convey possibility, use can or might instead.
To convey permission, use can instead.
See also can, could, might, must, should, and would.
https://developers.google.com/style/word-list#may

content/en/serverless/step_functions/installation.md Outdated Show resolved Hide resolved
Co-authored-by: Michael Cretzman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants