-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add common cmd+k use cases #26271
base: master
Are you sure you want to change the base?
Add common cmd+k use cases #26271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with a minor suggestion
Co-authored-by: Michael Cretzman <[email protected]>
Co-authored-by: Michael Cretzman <[email protected]>
everything else was great though! thank you so much for the speedy turn around on this! |
Thank you for your thorough and valuable feedback, @kdobesh ! I've applied all of it; please take another look 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great @janine-c thank you! Tim is OOO until Monday, but I think his will be minimal since we've been closely aligned throughout this project. nevertheless, we are going to wait til Monday to send our announcement email assuming that merging these docs won't take long after he approves it?
Great, thanks for approving, @kdobesh! If you want, I can go ahead and merge it today, and I can always create another PR if Tim has more feedback when he gets back. Otherwise, Monday works great. Once I add it to the merge queue, it can depend on what else is in there to get it live, but it shouldn't take too long to get it live. Just let me know what works best for you 🙂 |
What does this PR do? What is the motivation?
Adding some common examples of when to use
cmd
+k
to open the global search.Merge instructions
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/description
naming convention) and then add the following PR comment:Additional notes