Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common cmd+k use cases #26271

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

janine-c
Copy link
Contributor

What does this PR do? What is the motivation?

Adding some common examples of when to use cmd + k to open the global search.

Merge instructions

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@janine-c janine-c requested a review from a team as a code owner November 13, 2024 17:11
Copy link
Contributor

@michaelcretzman michaelcretzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with a minor suggestion

content/en/getting_started/application/_index.md Outdated Show resolved Hide resolved
content/en/logs/_index.md Outdated Show resolved Hide resolved
@kdobesh
Copy link

kdobesh commented Nov 14, 2024

everything else was great though! thank you so much for the speedy turn around on this!

@janine-c
Copy link
Contributor Author

Thank you for your thorough and valuable feedback, @kdobesh ! I've applied all of it; please take another look 🙂

Copy link

@kdobesh kdobesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great @janine-c thank you! Tim is OOO until Monday, but I think his will be minimal since we've been closely aligned throughout this project. nevertheless, we are going to wait til Monday to send our announcement email assuming that merging these docs won't take long after he approves it?

@janine-c
Copy link
Contributor Author

Great, thanks for approving, @kdobesh! If you want, I can go ahead and merge it today, and I can always create another PR if Tim has more feedback when he gets back. Otherwise, Monday works great. Once I add it to the merge queue, it can depend on what else is in there to get it live, but it shouldn't take too long to get it live. Just let me know what works best for you 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants