Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS-9826] azure container apps sidecar #27145

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

cswatt
Copy link
Contributor

@cswatt cswatt commented Jan 15, 2025

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@cswatt cswatt added the WORK IN PROGRESS No review needed, it's a wip ;) label Jan 15, 2025
@cswatt cswatt requested review from a team as code owners January 15, 2025 23:28
@github-actions github-actions bot added Images Images are added/removed with this PR Guide Content impacting a guide labels Jan 15, 2025
Copy link
Contributor

Copy link
Contributor

@brandondatadog brandondatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cswatt cswatt added editorial review Waiting on a more in-depth review and removed WORK IN PROGRESS No review needed, it's a wip ;) labels Jan 16, 2025
@cswatt
Copy link
Contributor Author

cswatt commented Jan 16, 2025

Added DOCS-9890 to track review

Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cswatt - This looks great! I just left a few minor suggestions for your consideration. 🚀

content/en/serverless/azure_container_apps/_index.md Outdated Show resolved Hide resolved
content/en/serverless/azure_container_apps/_index.md Outdated Show resolved Hide resolved
content/en/serverless/azure_container_apps/_index.md Outdated Show resolved Hide resolved
content/en/serverless/guide/aca_serverless_init.md Outdated Show resolved Hide resolved
content/en/serverless/guide/aca_serverless_init.md Outdated Show resolved Hide resolved

## Instrument your application

You can instrument your application in one of two ways: [Dockerfile](#dockerfile) or [buildpack](#buildpack).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There doesn't seem to be a buildpack section. Where is this supposed to link?

content/en/serverless/guide/aca_serverless_init.md Outdated Show resolved Hide resolved
content/en/serverless/guide/aca_serverless_init.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial review Waiting on a more in-depth review Guide Content impacting a guide Images Images are added/removed with this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants