Fix typos for runner upgrade #31796
Merged
Fix typos for runner upgrade #31796
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview links (active after the
|
joepeeples
approved these changes
Sep 23, 2025
| - RUNNER_ENROLLMENT_TOKEN=<the_token> | ||
| - DD_PRIVATE_RUNNER_CONFIG_DIR=/etc/dd-action-runner/config | ||
| - STATSD_ENABLED=true | ||
| # RUNNER_ENROLLMENT_TOKEN is not needed anymore |
There was a problem hiding this comment.
We could probably omit this comment, because it describes the past instead of the current state and requirements of the software.
If it'll genuinely help the reader to know this, though, it still seems a little distracting to mention in the code example. Maybe add a sentence above it, with less time-bound phrasing, such as:
"Navigate to the directory containing your docker-compose.yaml file. Note that RUNNER_ENROLLMENT_TOKEN is not required."
There was a problem hiding this comment.
Thanks for the feedback ! I removed the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Fix typos in the upgrade private runner page
Merge instructions
Merge readiness:
Additional notes