Skip to content

Conversation

@nhulston
Copy link
Contributor

@nhulston nhulston commented Nov 11, 2025

What does this PR do? What is the motivation?

  • In sidecar vs in-container comparison, remove the confusing "Observing multiple containers not supported for in-container".
    • Customers were understandably getting confused and thought this meant that the in-container approach is not supported when their app scales to multiple instances.
    • Rather, this was meant to explain that if they had multiple sidecar containers in a single instance, the sidecar approach could collect telemetry from all sidecar containers in that single instance.
    • I think it's best to remove this, because it is extremely rare that customers will have more than one container per instance, and we just want to avoid confusion.
  • Add image tag explanations to sidecar docs
  • Avoid referencing serverless-init:latest or serverless-init:1 references in docs. Rather, the customer should choose whatever image tag they want to use.

Merge instructions

Merge readiness:

  • Ready for merge

Additional notes

@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Nov 11, 2025
@nhulston nhulston changed the title Nicholas.hulston/serverless init fixes [Serverless-Init] Clean up docs to avoid confusion Nov 11, 2025
@nhulston nhulston changed the title [Serverless-Init] Clean up docs to avoid confusion [Serverless-Init] Reduce in-container vs sidecar confusion; explain serverless-init image tags Nov 11, 2025
@nhulston nhulston marked this pull request as ready for review November 11, 2025 19:45
@nhulston nhulston requested review from a team as code owners November 11, 2025 19:45
@cswatt cswatt self-assigned this Nov 11, 2025
@github-actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@nhulston nhulston merged commit fc64281 into master Nov 12, 2025
22 of 23 checks passed
@nhulston nhulston deleted the nicholas.hulston/serverless-init-fixes branch November 12, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Architecture Everything related to the Doc backend serverless

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants