Release 3.5 - v3.5.15-dd.1 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneesh1
force-pushed
the
aa/cherry-pick-v3.5.15-dd.1
branch
2 times, most recently
from
c111916
to
3a5b637
Compare
aneesh1
force-pushed
the
release-3.5-dd-v3.5.15-dd.1
branch
from
44e611b
to
9a55333
Compare
aneesh1
force-pushed
the
aa/cherry-pick-v3.5.15-dd.1
branch
3 times, most recently
from
ce1550c
to
282099b
Compare
badouralix
reviewed
Sep 30, 2024
There was a problem hiding this comment.
Overall lgtm up to the few changes we need to make to follow-up on etcd-io#18160
I am not exactly sure how we ended up modifying the certs in the test fixtures, it can be reverted to make this pull request simpler, but otherwise it is only a minor inconvenience
aneesh1
force-pushed
the
aa/cherry-pick-v3.5.15-dd.1
branch
2 times, most recently
from
881159b
to
8331a03
Compare
badouralix
reviewed
Oct 9, 2024
Cherry-pick etcd-io#13445 manually because the remote repository has been deleted, and add support for multiple values for allowed client and peer URIs Signed-off-by: Ayaz Badouraly <[email protected]>
aneesh1
force-pushed
the
aa/cherry-pick-v3.5.15-dd.1
branch
from
8331a03
to
cffd9c0
Compare
badouralix
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG for details.
Also includes a fix to support multiple SAN URIs in TLS peer verification - a feature used in
etcd-fabric.