Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Github Action ecosystem #527

Merged

Conversation

juliendoutre
Copy link
Contributor

After discussions with the team about #526, it seems having a dedicated ecosystem for github actions would be better from a UX point of view.

This PR makes the required changes to support scanning GitHub Action's JS (or TS) code using existing NPM source code rules.

@juliendoutre juliendoutre changed the title [SINT-2736] Add new GIthub Action ecosystem [SINT-2736] Add new Github Action ecosystem Feb 5, 2025
Copy link
Contributor

@sobregosodd sobregosodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor change requests

guarddog/analyzer/sourcecode/__init__.py Outdated Show resolved Hide resolved
guarddog/ecosystems.py Show resolved Hide resolved
guarddog/scanners/github_action_scanner.py Outdated Show resolved Hide resolved
guarddog/scanners/github_action_scanner.py Outdated Show resolved Hide resolved
guarddog/scanners/github_action_scanner.py Show resolved Hide resolved
@juliendoutre juliendoutre changed the title [SINT-2736] Add new Github Action ecosystem Add new Github Action ecosystem Feb 5, 2025
Copy link
Contributor

@ikretz ikretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@sobregosodd sobregosodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliendoutre juliendoutre merged commit 2e7999d into DataDog:main Feb 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants