updated spec, added some comments

DataDog · Oct 17, 2023 · ba41040 · ba41040
1 parent 63d7296
commit ba41040
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/windows_service/assets/configuration/spec.yaml b/windows_service/assets/configuration/spec.yaml
@@ -42,7 +42,7 @@ files:
                 - <SERVICE_NAME_1>
                 - name: <SERVICE_NAME_2>
                 - startup_type: automatic
-                  trigger_start: false
+                - trigger_start: false
           - name: disable_legacy_service_tag
             description: |
               Whether or not to stop submitting the tag `service` that has been renamed

diff --git a/windows_service/datadog_checks/windows_service/data/conf.yaml.example b/windows_service/datadog_checks/windows_service/data/conf.yaml.example
@@ -40,7 +40,7 @@ instances:
       - <SERVICE_NAME_1>
       - name: <SERVICE_NAME_2>
       - startup_type: automatic
-        trigger_start: false
+      - trigger_start: false
 
     ## @param disable_legacy_service_tag - boolean - optional - default: false
     ## Whether or not to stop submitting the tag `service` that has been renamed

diff --git a/windows_service/datadog_checks/windows_service/windows_service.py b/windows_service/datadog_checks/windows_service/windows_service.py
@@ -179,7 +179,8 @@ def trigger_count(self):
                 if e.winerror != winerror.ERROR_INSUFFICIENT_BUFFER:
                     raise
 
-            # allocate buffer and get trigger info, raise error if function returns 0
+            # allocate buffer and get trigger info
+            # raise any error from QueryServiceConfig2W
             bytesBuffer = ctypes.create_string_buffer(bytesneeded.value)
             QueryServiceConfig2W(
                 ctypes.c_void_p(self.hSvc.handle),