Fix incorrect binlog permissions errors (#18785)

DataDog · Oct 8, 2024 · efa33ba · efa33ba
1 parent 0b2723e
commit efa33ba
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/mysql/changelog.d/18785.fixed b/mysql/changelog.d/18785.fixed
@@ -0,0 +1 @@
+Fixed an incorrect warning when binary logs were disabled
diff --git a/mysql/datadog_checks/mysql/mysql.py b/mysql/datadog_checks/mysql/mysql.py
@@ -1079,7 +1079,10 @@ def _get_replica_stats(self, db, is_mariadb, replication_channel):
                 if binlog_results:
                     replica_results.update({'Binlog_enabled': True})
         except (pymysql.err.InternalError, pymysql.err.OperationalError) as e:
-            self.warning("Privileges error getting binlog information (must grant REPLICATION CLIENT): %s", e)
+            if "You are not using binary logging" in str(e):
+                replica_results.update({'Binlog_enabled': False})
+            else:
+                self.warning("Privileges error getting binlog information (must grant REPLICATION CLIENT): %s", e)
 
         return replica_results