Add hostname as part of the subscription substring #15189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
FlorentClarret
requested changes
Aug 16, 2023
steveny91
force-pushed
the
sy/ibm_ace_sub
branch
from
1d8b7ee
to
3a38868
Compare
FlorentClarret
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Tries to change the way we subscribe to an ibm mq instance. This will attach the hostname to the subscription, so that the name will be unique per host.
Motivation:
Escalation:
https://datadoghq.atlassian.net/browse/AGENT-9627
Customer sometimes uses multiple host with the same config to monitor ibm_mq instance. This could cause an issue when 2 host with the same config are trying to connect together, they'll get a 2429 error:
https://www.ibm.com/support/pages/multiple-instances-subscriber-same-clientid-are-receiving-reason-code-2429-mqrcsubscriptioninuse
This change aims at making the subscription name unique per host so that this doesn't happen.